Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK-11.5C] Refactor Widgets to TYPO3s new Pagination API #3091

Closed
1 task
Tracked by #2976
dkd-kaehm opened this issue Oct 29, 2021 · 7 comments
Closed
1 task
Tracked by #2976

[TASK-11.5C] Refactor Widgets to TYPO3s new Pagination API #3091

dkd-kaehm opened this issue Oct 29, 2021 · 7 comments

Comments

@dkd-kaehm
Copy link
Collaborator

dkd-kaehm commented Oct 29, 2021 •
edited
Loading

What should be done in the scope of this task?
All Widgets must be refactored to https://docs.typo3.org/m/typo3/reference-coreapi/11.5/en-us/ApiOverview/Pagination

Todo:
@dkd-kaehm dkd-kaehm mentioned this issue Oct 29, 2021
Closed
44 tasks
@dkd-kaehm
Copy link
Collaborator Author

@FamousWolf
Thanks for taking over this issue.

@FamousWolf
Copy link
Contributor

I'll take a quick look at it this week to see if I have any questions and will work on it next week.

@FamousWolf FamousWolf mentioned this issue Nov 17, 2021
Closed
@dkd-kaehm
Copy link
Collaborator Author

@FamousWolf
The search does not work currently, because of couple of Widgets used in EXT:solr.
See:

Do you want to continue with the rest of widgets? Or should someone else take it over?

@FamousWolf
Copy link
Contributor

Yes, I only replaced the pagination widget. I removed the other widgets from the template to test it. I'd love to tackle the other widgets as well, but I won't have time for it this week. If nobody else has time to work on it this week I can spend a few hours on it next week.

@FamousWolf
Copy link
Contributor

After discussing it with my team I've managed to free up some time this week. I've got 4 hours tomorrow or Wednesday to work on the widgets.

dkd-kaehm pushed a commit that referenced this issue Nov 27, 2021
@dkd-kaehm
[TASK] Refactor pagination
caf706a 
Relates: #3091, #2976
@dkd-kaehm
Copy link
Collaborator Author

@FamousWolf
Thanks for fixing the pagination part.
I've cherry-picked that PR in the target branch. Please use new pull request for rest of widget stuff.

dkd-kaehm pushed a commit that referenced this issue Nov 27, 2021
@dkd-kaehm
[TASK] Refactor pagination
4e5baf2 
Relates: #3091, #2976
@dkd-kaehm dkd-kaehm reopened this Nov 28, 2021
@FamousWolf FamousWolf mentioned this issue Nov 28, 2021
Closed
dkd-kaehm pushed a commit that referenced this issue Nov 29, 2021
@FamousWolf @dkd-kaehm
[TASK] Refactor LastSearches and FrequentlySearched widgets
03672c2 
Fixes: #3091
Relates: #2976
dkd-kaehm pushed a commit that referenced this issue Nov 29, 2021
@dkd-kaehm
[TASK] Refactor pagination
ed1b32a 
Relates: #3091, #2976
dkd-kaehm pushed a commit that referenced this issue Nov 29, 2021
@FamousWolf @dkd-kaehm
[TASK] Refactor LastSearches and FrequentlySearched widgets
2bfc641 
Fixes: #3091
Relates: #2976
dkd-kaehm pushed a commit to dkd-kaehm/ext-solr that referenced this issue Dec 2, 2021
@dkd-kaehm
[TASK] Refactor pagination
bb42410 
Relates: TYPO3-Solr#3091, TYPO3-Solr#2976
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Feb 3, 2022
@dkd-kaehm
Release 11.5.0-beta-1
6111cfe 
# A preview release 11.5.0 BETA-1 for TYPO3 11 LTS

## Huge improvements:

* [FEATURE] Get "free content mode" working
* [BUGFIX] TypoScript configuration for "Hide default language" sites

## Known issues:

* [BUG] Pagination breaks with 1573061766 exception on initial empty search without results
   TYPO3-Solr#3150
*  [BUG:11.5] Frequent Searches plugin does not work 
   TYPO3-Solr#3166

## Open tasks:

* [TASK] Migrate search/frontend templates to Bootstrap v5.1
   TYPO3-Solr#3112
* [TASK] Refactor Widgets to TYPO3s new Pagination API
   TYPO3-Solr#3091
* etc. small tasks
   See: The most up-to-date informations you'll get on:
   TYPO3-Solr#2976

# Note for non-composer instances:

This beta release is not available in TYPO3 TER, if you want to try this release,
please download and install this release manually from:

* https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.0-beta-1
  

---

# How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
   existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
   development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Feb 3, 2022
@dkd-kaehm
Release 11.5.0-beta-1
45d2175 
# A preview release 11.5.0 BETA-1 for TYPO3 11 LTS

## Huge improvements:

* [FEATURE] Get "free content mode" working
* [BUGFIX] TypoScript configuration for "Hide default language" sites

## Known issues:

* [BUG] Pagination breaks with 1573061766 exception on initial empty search without results
   TYPO3-Solr#3150
*  [BUG:11.5] Frequent Searches plugin does not work 
   TYPO3-Solr#3166

## Open tasks:

* [TASK] Migrate search/frontend templates to Bootstrap v5.1
   TYPO3-Solr#3112
* [TASK] Refactor Widgets to TYPO3s new Pagination API
   TYPO3-Solr#3091
* etc. small tasks
   See: The most up-to-date informations you'll get on:
   TYPO3-Solr#2976

## Note for non-composer instances:

This beta release is not available in TYPO3 TER, if you want to try this release,
please download and install this release manually from:

* https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.0-beta-1
  

---

# How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
   existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
   development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
@dkd-kaehm dkd-kaehm mentioned this issue Feb 3, 2022
Merged
dkd-kaehm added a commit that referenced this issue Feb 3, 2022
@dkd-kaehm
Release 11.5.0-beta-1
85d2609 
# A preview release 11.5.0 BETA-1 for TYPO3 11 LTS

## Huge improvements:

* [FEATURE] Get "free content mode" working
* [BUGFIX] TypoScript configuration for "Hide default language" sites

## Known issues:

* [BUG] Pagination breaks with 1573061766 exception on initial empty search without results
   #3150
*  [BUG:11.5] Frequent Searches plugin does not work 
   #3166

## Open tasks:

* [TASK] Migrate search/frontend templates to Bootstrap v5.1
   #3112
* [TASK] Refactor Widgets to TYPO3s new Pagination API
   #3091
* etc. small tasks
   See: The most up-to-date informations you'll get on:
   #2976

## Note for non-composer instances:

This beta release is not available in TYPO3 TER, if you want to try this release,
please download and install this release manually from:

* https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.0-beta-1
  

---

# How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
   existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
   development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this issue Feb 9, 2022
@dkd-friedrich
Release 11.5.0-beta-2
05729f9 
# A preview release 11.5.0 BETA-2 for TYPO3 11 LTS

## Huge improvements:

* [P:11.5:FEATURE] Improve data update handling

## Known issues:

* [BUG] Pagination breaks with 1573061766 exception on initial empty
search without results
   TYPO3-Solr#3150
*  [BUG:11.5] Frequent Searches plugin does not work
   TYPO3-Solr#3166

## Open tasks:

* [TASK] Migrate search/frontend templates to Bootstrap v5.1
   TYPO3-Solr#3112
* [TASK] Refactor Widgets to TYPO3s new Pagination API
   TYPO3-Solr#3091
* etc. small tasks
   See: The most up-to-date informations you'll get on:
   TYPO3-Solr#2976

## Note for non-composer instances:

This beta release is not available in TYPO3 TER, if you want to try this
release,
please download and install this release manually from:

* https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.0-beta-1


---

# How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
   existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
   development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
@dkd-friedrich dkd-friedrich mentioned this issue Feb 9, 2022
Closed
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this issue Feb 9, 2022
@dkd-friedrich
Release 11.5.0-beta-2
08835bc 
# A preview release 11.5.0 BETA-2 for TYPO3 11 LTS

## Huge improvements:

* [P:11.5:FEATURE] Improve data update handling

## Known issues:

* [BUG] Pagination breaks with 1573061766 exception on initial empty
search without results
   TYPO3-Solr#3150
*  [BUG:11.5] Frequent Searches plugin does not work
   TYPO3-Solr#3166

## Open tasks:

* [TASK] Migrate search/frontend templates to Bootstrap v5.1
   TYPO3-Solr#3112
* [TASK] Refactor Widgets to TYPO3s new Pagination API
   TYPO3-Solr#3091
* etc. small tasks
   See: The most up-to-date informations you'll get on:
   TYPO3-Solr#2976

## Note for non-composer instances:

This beta release is not available in TYPO3 TER, if you want to try this
release,
please download and install this release manually from:

* https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.0-beta-1


---

# How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
   existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
   development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
@dkd-friedrich dkd-friedrich mentioned this issue Feb 9, 2022
Merged
dkd-friedrich added a commit that referenced this issue Feb 9, 2022
@dkd-friedrich
Release 11.5.0-beta-2
91016b1 
# A preview release 11.5.0 BETA-2 for TYPO3 11 LTS

## Huge improvements:

* [P:11.5:FEATURE] Improve data update handling

## Known issues:

* [BUG] Pagination breaks with 1573061766 exception on initial empty
search without results
   #3150
*  [BUG:11.5] Frequent Searches plugin does not work
   #3166

## Open tasks:

* [TASK] Migrate search/frontend templates to Bootstrap v5.1
   #3112
* [TASK] Refactor Widgets to TYPO3s new Pagination API
   #3091
* etc. small tasks
   See: The most up-to-date informations you'll get on:
   #2976

## Note for non-composer instances:

This beta release is not available in TYPO3 TER, if you want to try this
release,
please download and install this release manually from:

* https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.0-beta-1


---

# How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
   existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
   development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
@bmack
Copy link
Collaborator

bmack commented Feb 23, 2022

See my branch here https://github.com/bmack/ext-solr/tree/grouping-pagination-widgets that works with grouped search results and the new Pagination API. No tests or template adaptions are done. But the branch works for our current project.
In addition, the "old" WidgetControllers* things in EXT:solr could now be removed at the same time as they depend on EXT:fluid v10.

@dkd-kaehm dkd-kaehm mentioned this issue Mar 10, 2022
Closed
@dkd-friedrich dkd-friedrich mentioned this issue Mar 14, 2022
Closed
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this issue Mar 14, 2022
@dkd-friedrich
Release 11.5.0-rc-1
2c2b13d 
# First release candidate of 11.5.0 for TYPO3 11 LTS

## Huge improvements:

* TYPO3 11 LTS compatibility
* [P:11.5:FEATURE] Improve data update handling

## Known issues:

* [BUG:11.5] Frequent Searches plugin does not work TYPO3-Solr#3166

## Open tasks:

* [BUG] PHP Warning: Undefined array key "TSFE" in RootPageResolver.php
TYPO3-Solr#3173
* [TASK-11.5C] Refactor Widgets to TYPO3s new Pagination API TYPO3-Solr#3091
* [TASK] Finalize lastSearches Integration test cases TYPO3-Solr#3160

## Note for non-composer instances:

This release candidate is not available in TYPO3 TER, if you want to try
this
release, please download and install this release manually from:

* https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.0-rc-1


---

# How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
   existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
   development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
@dkd-friedrich dkd-friedrich mentioned this issue Mar 14, 2022
Merged
@dkd-kaehm dkd-kaehm mentioned this issue Aug 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmack @FamousWolf @dkd-kaehm