[BUG] PHP Warning: Return value of SiteUtility::getConnectionProperty() must be of the type string

[SSFGizmo]

(1/1) TypeError

Return value of ApacheSolrForTypo3\Solr\System\Util\SiteUtility::getConnectionProperty() must be of the type string, null returned
in /solr/Classes/System/Util/SiteUtility.php line 81

I try to save one tt_content element on the page under "Page 2"

Root 1 (with site configuration 1)
 Page 1
 Root 2
   Page 2 (with site configuration 2)

• TYPO3 Version: 11.5.17
• EXT:solr Version: 99a5c11
• PHP Version: 7.4.30

[dkd-kaehm]

@SSFGizmo
Thanks for reporting that issue.
There is a logic trouble in this method:

in release-11.5.x:

ext-solr/Classes/System/Util/SiteUtility.php

Lines 72 to 84 in 61076e3

	public static function getConnectionProperty(
	Site $typo3Site,
	string $property,
	int $languageId,
	string $scope,
	$defaultValue = null
	): string {
	$value = self::getConnectionPropertyOrFallback($typo3Site, $property, $languageId, $scope);
	if ($value === null) {
	return $defaultValue;
	}
	return $value;
	}

in release-11.2.x: as well:

ext-solr/Classes/System/Util/SiteUtility.php

Lines 85 to 92 in 8af8a64

	public static function getConnectionProperty(Site $typo3Site, string $property, int $languageId, string $scope, string $defaultValue = null): string
	{
	$value = self::getConnectionPropertyOrFallback($typo3Site, $property, $languageId, $scope);
	if ($value === null) {
	return $defaultValue;
	}
	return $value;
	}

Solution

Return type must be "mixed", because multiple calls set the mixed $defaultValue.

Target versions:

• release-11.2.x
• release-11.5.x
• main