Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] numeric facet range slider sends lot of requests to server #4082

Closed
hvomlehn-sds opened this issue Jun 3, 2024 · 1 comment
Closed

Comments

@hvomlehn-sds
Copy link
Contributor

Describe the bug
When using a numeric range with a slider facet, the facet updates continously while sliding the slider with the mouse. Updating the UI to show the curretly slided to value is appreciated. However, the component sends the new facet-setting to the server during the slide as well.

Expected behavior
The jQuery-API of the slider component provides a stop-event in addition to the sliede event. The stop-event should be used to trigger the url update only, so that server requests are only sent, once the user releases the slider.

Used versions (please complete the following information):

  • TYPO3 Version: 12.4.15
  • Browser: Firefox, Chromium, probably any browser
  • EXT:solr Version: 12.0.3
@hvomlehn-sds
Copy link
Contributor Author

I have a fix for this ready and will submit a PR soon.

@dkd-kaehm dkd-kaehm changed the title numeric facet range slider sends lot of events to server [BUG] numeric facet range slider sends lot of events to server Jun 6, 2024
@dkd-kaehm dkd-kaehm changed the title [BUG] numeric facet range slider sends lot of events to server [BUG] numeric facet range slider sends lot of requests to server Jun 6, 2024
dkd-kaehm pushed a commit that referenced this issue Jun 6, 2024
Previously the numeric range slider updated the UI and the facet setting continously during sliding. This caused a lot of get requests to the server. This PR changes the desired behavior to send update requests only once the user releases the slider. The UI still gets updated continuously by using the separate slide-event for that.

Fixes: #4082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant