Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Make TYPO3 11 LTS compatible #2977

Conversation

sorenmalling
Copy link
Contributor

@sorenmalling sorenmalling commented Jul 14, 2021

What this pr does

Change namespaces for

  • PageRepository
  • ApplicationContext
  • Configured backend modules classes

To be able to install in TYPO3 11

How to test

Install the extension without the PR to get fatal errors about unknown method and class names

Fixes: #2976

@dkd-kaehm dkd-kaehm force-pushed the task/install-in-11.3 branch 4 times, most recently from 316f117 to a7d16d0 Compare August 18, 2021 15:05
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 22, 2021
This change is the first step to TYPO3 11 LTS compatibility.
We'll test against current TYPO3 11 release and dev-master.

PHP <7.4 support dropped.

Relates: TYPO3-Solr#2977, TYPO3-Solr#2999
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 22, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 22, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 22, 2021
dkd-kaehm added a commit that referenced this pull request Oct 22, 2021
This change is the first step to TYPO3 11 LTS compatibility.
We'll test against current TYPO3 11 release and dev-master.

PHP <7.4 support dropped.

Relates: #2977, #2999
dkd-kaehm added a commit that referenced this pull request Oct 22, 2021
@dkd-kaehm dkd-kaehm mentioned this pull request Oct 22, 2021
19 tasks
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 22, 2021
This change is the first step to TYPO3 11 LTS compatibility.
We'll test against current TYPO3 11 release and dev-master.

PHP <7.4 support dropped.

Relates: TYPO3-Solr#2977, TYPO3-Solr#2999
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 22, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 22, 2021
dkd-kaehm added a commit that referenced this pull request Oct 22, 2021
This change is the first step to TYPO3 11 LTS compatibility.
We'll test against current TYPO3 11 release and dev-master.

PHP <7.4 support dropped.

Relates: #2977, #2999
dkd-kaehm added a commit that referenced this pull request Oct 22, 2021
dkd-kaehm added a commit that referenced this pull request Oct 22, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 22, 2021
dkd-kaehm added a commit that referenced this pull request Oct 22, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 23, 2021
This change contains:
* Basic integration of GitHub Actions
  * Caching of:
    * docker image
    * using Docker image instead of Apache solr installation script
    * composer installation state caching aware of:
       * TYPO3 git commit hash of required version
       * solarium/solarium versions string
       * PHP version
   Results to 11 seconds on caching vs 4:30 minutes on composer install.
* Use single workflow file within multiple branches, but different build matrix settings for them.
* Integration of Tailor to publish releases in TER
   * Run "Publish new version to TER" on PHP version declared in
     `Resources/Private/Php/ComposerLibraries/composer.json`
      '.config.platform.php'`
* Allow to fail the jobs from matrix within TYPO3 `-dev` versions.
* Uploads the coverage to Scrutinizer

Relates: TYPO3-Solr#2977, TYPO3-Solr#2999, TYPO3-Solr#3072
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 23, 2021
This change contains:
* Basic integration of GitHub Actions
  * Caching of:
    * docker image
    * using Docker image instead of Apache solr installation script
    * composer installation state caching aware of:
       * TYPO3 git commit hash of required version
       * solarium/solarium versions string
       * PHP version
   Results to 11 seconds on caching vs 4:30 minutes on composer install.
* Use single workflow file within multiple branches, but different build matrix settings for them.
* Integration of Tailor to publish releases in TER
   * Run "Publish new version to TER" on PHP version declared in
     `Resources/Private/Php/ComposerLibraries/composer.json`
      '.config.platform.php'`
* Allow to fail the jobs from matrix within TYPO3 `-dev` versions.
* Uploads the coverage to Scrutinizer

Relates: TYPO3-Solr#2977, TYPO3-Solr#2999, TYPO3-Solr#3072
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 23, 2021
This change contains:
* Basic integration of GitHub Actions
  * Caching of:
    * docker image
    * using Docker image instead of Apache solr installation script
    * composer installation state caching aware of:
       * TYPO3 git commit hash of required version
       * solarium/solarium versions string
       * PHP version
   Results to 11 seconds on caching vs 4:30 minutes on composer install.
* Use single workflow file within multiple branches, but different build matrix settings for them.
* Integration of Tailor to publish releases in TER
   * Run "Publish new version to TER" on PHP version declared in
     `Resources/Private/Php/ComposerLibraries/composer.json`
      '.config.platform.php'`
* Allow to fail the jobs from matrix within TYPO3 `-dev` versions.
* Uploads the coverage to Scrutinizer

Relates: TYPO3-Solr#2977, TYPO3-Solr#2999, TYPO3-Solr#3072
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 23, 2021
This change contains:
* Basic integration of GitHub Actions
  * Caching of:
    * docker image
    * using Docker image instead of Apache solr installation script
    * composer installation state caching aware of:
       * TYPO3 git commit hash of required version
       * solarium/solarium versions string
       * PHP version
   Results to 11 seconds on caching vs 4:30 minutes on composer install.
* Use single workflow file within multiple branches, but different build matrix settings for them.
* Integration of Tailor to publish releases in TER
   * Run "Publish new version to TER" on PHP version declared in
     `Resources/Private/Php/ComposerLibraries/composer.json`
      '.config.platform.php'`
* Allow to fail the jobs from matrix within TYPO3 `-dev` versions.
* Uploads the coverage to Scrutinizer

Relates: TYPO3-Solr#2977, TYPO3-Solr#2999, TYPO3-Solr#3072
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 24, 2021
This change contains:
* Basic integration of GitHub Actions
  * Caching of:
    * docker image
    * using Docker image instead of Apache solr installation script
    * composer installation state caching aware of:
       * TYPO3 git commit hash of required version
       * solarium/solarium versions string
       * PHP version
   Results to 11 seconds on caching vs 4:30 minutes on composer install.
* Use single workflow file within multiple branches, but different build matrix settings for them.
* Integration of Tailor to publish releases in TER
   * Run "Publish new version to TER" on PHP version declared in
     `Resources/Private/Php/ComposerLibraries/composer.json`
      '.config.platform.php'`
* Allow to fail the jobs from matrix within TYPO3 `-dev` versions.
* Uploads the coverage to Scrutinizer

Relates: TYPO3-Solr#2977, TYPO3-Solr#2999, TYPO3-Solr#3072
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 24, 2021
This change contains:
* Basic integration of GitHub Actions
  * Caching of:
    * docker image
    * using Docker image instead of Apache solr installation script
    * composer installation state caching aware of:
       * TYPO3 git commit hash of required version
       * solarium/solarium versions string
       * PHP version
   Results to 11 seconds on caching vs 4:30 minutes on composer install.
* Use single workflow file within multiple branches, but different build matrix settings for them.
* Integration of Tailor to publish releases in TER
   * Run "Publish new version to TER" on PHP version declared in
     `Resources/Private/Php/ComposerLibraries/composer.json`
      '.config.platform.php'`
* Allow to fail the jobs from matrix within TYPO3 `-dev` versions.
* Uploads the coverage to Scrutinizer

Relates: TYPO3-Solr#2977, TYPO3-Solr#2999, TYPO3-Solr#3072
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 24, 2021
This change contains:
* Basic integration of GitHub Actions
  * Caching of:
    * docker image
    * using Docker image instead of Apache solr installation script
    * composer installation state caching aware of:
       * TYPO3 git commit hash of required version
       * solarium/solarium versions string
       * PHP version
   Results to 11 seconds on caching vs 4:30 minutes on composer install.
* Use single workflow file within multiple branches, but different build matrix settings for them.
* Integration of Tailor to publish releases in TER
   * Run "Publish new version to TER" on PHP version declared in
     `Resources/Private/Php/ComposerLibraries/composer.json`
      '.config.platform.php'`
* Allow to fail the jobs from matrix within TYPO3 `-dev` versions.
* Uploads the coverage to Scrutinizer

Relates: TYPO3-Solr#2977, TYPO3-Solr#2999, TYPO3-Solr#3072
dkd-kaehm added a commit that referenced this pull request Nov 29, 2021
With this change, the root pages of configured sites are imported by default, if `writeDefaultSolrTestSiteConfiguration()` is called.

To skip the import of records for root pages, the test class property  $skipImportRootPagesAndTemplatesForConfiguredSites must be set to false.

To add or override TypoScript setting please use following typo3/testing-framework methods:
* `addTypoScriptToTemplateRecord()`
* `setUpFrontendRootPage()`

The usage of this feature will be implemented in subsequent commits. 

Fixes: #3092
Relates: #2976, #2977
dkd-kaehm added a commit that referenced this pull request Nov 29, 2021
dkd-kaehm added a commit that referenced this pull request Nov 29, 2021
dkd-kaehm added a commit that referenced this pull request Nov 29, 2021
dkd-kaehm added a commit that referenced this pull request Nov 29, 2021
dkd-kaehm added a commit that referenced this pull request Nov 29, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
This change is the first step to TYPO3 11 LTS compatibility.
We'll test against current TYPO3 11 release and dev-master.

PHP <7.4 support dropped.

Relates: TYPO3-Solr#2977, TYPO3-Solr#2999
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
This change contains changes for back-end module templates
related to Bootstrap 5 changes.

Relates: TYPO3-Solr#2977
Fixes: TYPO3-Solr#2976
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
This change contains basic fixes for TSFE initialization.

Relates: TYPO3-Solr#2977
Fixes: TYPO3-Solr#2976
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
Notes:

* Replaces `GeneralUtility::isFirstPartOfStr()` with 
   PHP8(or Symfony Polyfills 8.0) `str_starts_with()`  

Fixes: TYPO3-Solr#3089
Relates: TYPO3-Solr#2976, TYPO3-Solr#2977
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
This change contains array key access fixes only.

Fixes: TYPO3-Solr#3089
Relates: TYPO3-Solr#2976, TYPO3-Solr#2977
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
* TYPO3 11 LTS uses native Guzzle PSR-18 implementation 
   See: TYPO3/typo3@997c066

Fixes: TYPO3-Solr#3092
Relates: TYPO3-Solr#2976, TYPO3-Solr#2977
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
The initialization of TSFE within indexing and  Backens modules contexts is refactored.

In this change the setting and usage of $GLOBALS['TSFE'] is removed and replaced by TYPO3s Core Context API.
The "Context" is always cloned instead of using its singleton instance.
The "Context", "Language", "TSFE" and "ServerRequest", which are required for TypoScript parsing in BE-modules and indexing contexts, are highly isolated/capsuled and not visible anymore for all things not belonging to EXT:solr internals.

Byside of isolation/capsulation of TSFE, the language handling is restored 
to pure and default EXT:solr "fallback" mode approach. 
So all page records, which are involved in indexing(All page types and above all all with sys_template or records-to-index), must be translated. Otherwise the translation records will be indexed in default language.

Note: Since TYPO3 11 LTS does not allow to instanciate TSFE for sys folders and spacer, the initialization of TSFE will be done for first and closest page(not spacer or folder) within the site rootline.  

Note: This change is not a final state of EXT:solr 11.5.x 

Fixes: TYPO3-Solr#3092, 3065
Relates: TYPO3-Solr#2976, TYPO3-Solr#2977
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
With this change, the root pages of configured sites are imported by default, if `writeDefaultSolrTestSiteConfiguration()` is called.

To skip the import of records for root pages, the test class property  $skipImportRootPagesAndTemplatesForConfiguredSites must be set to false.

To add or override TypoScript setting please use following typo3/testing-framework methods:
* `addTypoScriptToTemplateRecord()`
* `setUpFrontendRootPage()`

The usage of this feature will be implemented in subsequent commits. 

Fixes: TYPO3-Solr#3092
Relates: TYPO3-Solr#2976, TYPO3-Solr#2977
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epic [TASK] Make EXT:solr TYPO3 11 LTS compatible
2 participants