[BUGFIX] Shortcircuit work in SolrRoutingMiddleware #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophlehmann
force-pushed
the
fix-3202-superflous-logging
branch
2 times, most recently
from
0805a95 to
d422688
Compare
dkd-kaehm
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
@christophlehmann
Thanks for fixing that issue.
We want back-ports.
Is EXT:solr 11.2.x affected as well?
|
Yes, 11.2 ist affected as well. You can cherry-pick it without further changes. |
Shortcircuit work in SolrRoutingMiddleware like in PageIndexerFinisher: When a request does not have the X-Tx-Solr-Iq header, then it's not interesting for the Solr extension. Background: Superflous logging 'Could not resolve page by path...' to Solr logfile. Relates: TYPO3-Solr#3202
dkd-kaehm
force-pushed
the
fix-3202-superflous-logging
branch
from
d422688 to
320be8e
Compare
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Sep 9, 2022
Shortcircuit work in SolrRoutingMiddleware like in PageIndexerFinisher: When a request does not have the X-Tx-Solr-Iq header, then it's not interesting for the Solr extension. Background: Superflous logging 'Could not resolve page by path...' to Solr logfile. Relates: TYPO3-Solr#3202 Ports: TYPO3-Solr#3339
dkd-kaehm
pushed a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Sep 9, 2022
Shortcircuit work in SolrRoutingMiddleware like in PageIndexerFinisher: When a request does not have the X-Tx-Solr-Iq header, then it's not interesting for the Solr extension. Background: Superflous logging 'Could not resolve page by path...' to Solr logfile. Relates: TYPO3-Solr#3202 Ports: TYPO3-Solr#3339
This was referenced Sep 9, 2022
|
@christophlehmann The change is already in v 11.2 but the log entries doesn't stop (within TYPO3 10) |
@josefglatz |
|
Thank you
Diese Nachricht wurde von meinem Smartphone versandt
… Am 20.10.2022 um 12:18 schrieb Rafael Kähm ***@***.***>:
@christophlehmann The change is already in v 11.2 but the log entries doesn't stop (within TYPO3 10)
@josefglatz
Please make sure dev-release-11.2.x is loaded. There is no stable 11.2.x release now with this change.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
Shortcircuit work in SolrRoutingMiddleware like in PageIndexerFinisher: When a request does not have the X-Tx-Solr-Iq header, then it's not interesting for the Solr extension.
Background: Superflous logging 'Could not resolve page by path...' to Solr logfile.
How to test
Fixes: #3202