[BUGFIX] Fix array key access in ext_getSetup #3360
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
Reading nested TypoScript will no longer log a warning when the value can not be accessed. In this case, the second value in the array returned in
TypoScript::ext_getSetup
will be an empty string. However, the second value is not used by Ext:solr anymore.This also fixes an issue with PHP 8 where such warning would cause the indexing to fail, when the method is used inside of an indexer.
How to test
Set in TypoScript setup:
Place this snipped inside a Solr indexer or Solr indexer hook:
Indexing should no longer produce a PHP warning and it should succeed in PHP 8.
Fixes: #3359