[TASK] Introduce index queue type setting #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkd-friedrich
force-pushed
the
task/main/3364-introduce_queue_type_setting
branch
2 times, most recently
from
b9076f3 to
800e039
Compare
Queue types shouldn't be restricted to internal data, which is already prepared in some classes. As index queue setting 'table' suggests that a local table is expected, this is replaced with a new setting 'type'. queue.[indexConfig].table is now deprecated and will be removed in v13, 'type' should be used instead. Resolves: TYPO3-Solr#3365
dkd-friedrich
force-pushed
the
task/main/3364-introduce_queue_type_setting
branch
from
800e039 to
d281bf6
Compare
dkd-kaehm
approved these changes
Oct 20, 2022
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Oct 20, 2022
Queue types shouldn't be restricted to internal data, which is already prepared in some classes. As index queue setting 'table' suggests that a local table is expected, this is replaced with a new setting 'type'. queue.[indexConfig].table is now deprecated and will be removed in v13, 'type' should be used instead. Resolves: TYPO3-Solr#3365
dkd-kaehm
pushed a commit
that referenced
this pull request
Oct 20, 2022
Queue types shouldn't be restricted to internal data, which is already prepared in some classes. As index queue setting 'table' suggests that a local table is expected, this is replaced with a new setting 'type'. queue.[indexConfig].table is now deprecated and will be removed in v13, 'type' should be used instead. Resolves: #3365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
Queue types shouldn't be restricted to internal data, which is already prepared in some classes. As index queue setting 'table' suggests that a local table is expected, this is replaced with a new setting 'type'.
queue.[indexConfig].tableis now deprecated and will be removed in v13, 'type' should be used instead.How to test
Configure an indexing configuration and configure the local table via
typeinstead oftableFixes: #3364