Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Type-hinting for SiteUtility::getConnectionProperty() #3395

Merged
merged 1 commit into from
Nov 9, 2022
Merged

[BUGFIX] Type-hinting for SiteUtility::getConnectionProperty() #3395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Classes/System/Util/SiteUtility.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ public static function getIsSiteManagedSite(int $pageId): bool
* The configuration is done in the globals configuration of a site, and be extended in the language specific configuration
* of a site.
*
* Typically everything except the core name is configured on the global level and the core name differs for each language.
* Typically, everything except the core name is configured on the global level and the core name differs for each language.
*
* In addition every property can be defined for the ```read``` and ```write``` scope.
* In addition, every property can be defined for the ```read``` and ```write``` scope.
*
* The convention for property keys is "solr_{propertyName}_{scope}". With the configuration "solr_host_read" you define the host
* for the solr read connection.
Expand All @@ -79,10 +79,10 @@ public static function getIsSiteManagedSite(int $pageId): bool
* @param string $property
* @param int $languageId
* @param string $scope
* @param string $defaultValue
* @return string
* @param mixed $defaultValue
* @return mixed
*/
public static function getConnectionProperty(Site $typo3Site, string $property, int $languageId, string $scope, string $defaultValue = null): string
public static function getConnectionProperty(Site $typo3Site, string $property, int $languageId, string $scope, $defaultValue = null)
{
$value = self::getConnectionPropertyOrFallback($typo3Site, $property, $languageId, $scope);
if ($value === null) {
Expand Down