Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK:BP:11.6] Relax dependencies to local tables #3765

Conversation

dkd-friedrich
Copy link
Member

@dkd-friedrich dkd-friedrich commented Aug 22, 2023

Backport of #3764

DO NOT MERGE! Base has to be 11.6!

What this pr does

To allow indexing of external data the dependencies to local tables are relaxed, 4 steps are prepared to achieve this:

  • !!![BUGFIX] Queue check considers indexing configuration
  • !!![TASK] Introduce queue and queue item interfaces
  • [TASK] Consider queue initialization status]
  • !!![TASK] Introduce specific EXT:solr exceptions

Most of these changes are breaking, as internal interfaces and exceptions are changed, that might be used outside of EXT:solr.

How to test

This changes just prepares EXT:solr for indexing of external data, the current behaviour is not changed!

Resolves: #3763

As there may be several indexing configurations per type the
queue check has to consider the indexing configuration. The
missing check is added by this commit.

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
As an initial steps to allow custom index queue types interfaces
for queue and queue items are introduced. Additionally custom
queue classes can be configured via:
plugin.tx_solr.index.queue.<configurationName>.indexQueue

This is a breaking change for all instances that implemented own queues
and queue items!

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
Queue initialization status returned by the QueueInitializationService
isn't considered in the backend module and a success message is always
shown. This commit adds a check for the returned status and displays an
error message similiar to the message that is shown if an exceptions
occured.

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
Existing exceptions are now based on the recently introduced
generic EXT:solr exception.

Additionally based on the new generic EXT:solr exception a further
exception is introduced, allowing more targeted handling of exceptions:
InvalidIndexQueueInitizalizationPostProcessorException

This is a breaking change as the base excepion changed and the new
exception is no longer based on \UnexpectedValueException.

Ports: TYPO3-Solr#3764
Resolves: TYPO3-Solr#3763
@dkd-friedrich
Copy link
Member Author

DO NOT MERGE! Base has to be 11.6!

@dkd-kaehm dkd-kaehm changed the base branch from release-11.5.x to release-11.6.x September 15, 2023 08:00
@dkd-kaehm dkd-kaehm merged commit e3a915c into TYPO3-Solr:release-11.6.x Sep 15, 2023
@dkd-kaehm dkd-kaehm deleted the task/release-11.6.x/3763-relax_dependency_to_local_tables branch September 15, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants