[TASK] Migrate javascript modules #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JavaScript top.fsMod is deprecated since TYPO3 11.4, this commit replaces the old top.fsMod usage with the ModuleStateStorage, now the ImmediateActionElement is used. Resolves: TYPO3-Solr#3489
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Sep 21, 2023
JavaScript top.fsMod is deprecated since TYPO3 11.4, this commit replaces the old top.fsMod usage with the ModuleStateStorage, now the ImmediateActionElement is used. Ports: TYPO3-Solr#3794 Resolves: TYPO3-Solr#3489
RequireJS integration is deprecated in TYPO3 12 and will be removed with TYPO3 13, thus search statistics JavaScript is adapted for ECMAScript v6. An update to Chart.js 3.9.1 is also done, which provides ES6 support. Integration in Chart.js 4 is currently faulty and is postponed. Resolves: TYPO3-Solr#3489
dkd-friedrich
force-pushed
the
task/main/3489-migrate_javascript_modules
branch
from
91e9306 to
3533d32
Compare
dkd-kaehm
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
How to test
top.fsMod
ModuleStateStorage.current('searchbackend')=> Selected page should be stored in the
ModuleStateStorageSearchStatistics.js
plugin.tx_solr.statistics = 1=> Statistic chart should be rendered
Fixes: #3489