[BUGFIX] Make getHasChildNodeSelected recursive #4156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twojtylak
force-pushed
the
fix/make-node-get-has-child-node-selected-recursive
branch
2 times, most recently
from
0cac418 to
fde89a4
Compare
dkd-kaehm
force-pushed
the
release-12.0.x
branch
from
6a73614 to
fe7c9eb
Compare
dkd-kaehm
force-pushed
the
fix/make-node-get-has-child-node-selected-recursive
branch
from
fde89a4 to
cabde1d
Compare
|
@twojtylak |
twojtylak
force-pushed
the
fix/make-node-get-has-child-node-selected-recursive
branch
from
cabde1d to
9191a7b
Compare
|
The test fail because of changes in TYPO3 Fluid. |
dkd-kaehm
force-pushed
the
fix/make-node-get-has-child-node-selected-recursive
branch
from
9191a7b to
7195f35
Compare
dkd-kaehm
force-pushed
the
fix/make-node-get-has-child-node-selected-recursive
branch
from
7195f35 to
3f58e21
Compare
dkd-kaehm
force-pushed
the
fix/make-node-get-has-child-node-selected-recursive
branch
from
3f58e21 to
c05379b
Compare
Currently, the GetHasChildNodeSelected function in \ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Hierarchy\Node only checks whether a direct child is selected. With hierarchical filters, however, it makes sense to check whether any child is selected in this hierarchy branch. E.g. because this should be expanded in the frontend.
```html
<f:if condition="{childNode.hasChildNodeSelected}">
<f:variable name="detailsState" value="open" />
</f:if>
```
The PR implements this recursive check.
Fixes: TYPO3-Solr#4155
dkd-kaehm
force-pushed
the
fix/make-node-get-has-child-node-selected-recursive
branch
from
c05379b to
bdcd030
Compare
dkd-kaehm
pushed a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Dec 12, 2024
Currently, the GetHasChildNodeSelected function in \ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Hierarchy\Node only checks whether a direct child is selected. With hierarchical filters, however, it makes sense to check whether any child is selected in this hierarchy branch. E.g. because this should be expanded in the frontend.
```html
<f:if condition="{childNode.hasChildNodeSelected}">
<f:variable name="detailsState" value="open" />
</f:if>
```
The PR implements this recursive check.
Fixes: TYPO3-Solr#4155
Ports: TYPO3-Solr#4156
dkd-kaehm
pushed a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Dec 12, 2024
Currently, the GetHasChildNodeSelected function in \ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Hierarchy\Node only checks whether a direct child is selected. With hierarchical filters, however, it makes sense to check whether any child is selected in this hierarchy branch. E.g. because this should be expanded in the frontend.
```html
<f:if condition="{childNode.hasChildNodeSelected}">
<f:variable name="detailsState" value="open" />
</f:if>
```
The PR implements this recursive check.
Fixes: TYPO3-Solr#4155
Ports: TYPO3-Solr#4156
dkd-kaehm
pushed a commit
that referenced
this pull request
Dec 17, 2024
Currently, the GetHasChildNodeSelected function in \ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Hierarchy\Node only checks whether a direct child is selected. With hierarchical filters, however, it makes sense to check whether any child is selected in this hierarchy branch. E.g. because this should be expanded in the frontend.
```html
<f:if condition="{childNode.hasChildNodeSelected}">
<f:variable name="detailsState" value="open" />
</f:if>
```
The PR implements this recursive check.
Fixes: #4155
Ports: #4156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
Currently, the GetHasChildNodeSelected function in \ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Hierarchy\Node only checks whether a direct child is selected. With hierarchical filters, however, it makes sense to check whether any child is selected in this hierarchy branch. E.g. because this should be expanded in the frontend.
The PR implements this recursive check.
Fixes: #4155