!!![TASK] Remove JSONP callback in suggest #4267
Open
+13
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
This change removes the callback logic in the Suggest AJAX Call via JSONP, as JSONP is known to be used to call untrusted third-party code, and can thus be removed, as custom suggest code is done anyway via custom JS implementations. See https://en.wikipedia.org/wiki/JSONP#Security_concerns Fixes: TYPO3-Solr#2556 Ports: TYPO3-Solr#4201
dkd-kaehm
force-pushed
the
port/4201_to_12.0.x
branch
from
eddc731 to
03e6327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the callback logic
in the Suggest AJAX Call via JSONP, as JSONP
is known to be used to call untrusted third-party
code, and can thus be removed, as custom suggest
code is done anyway via custom JS implementations.
See https://en.wikipedia.org/wiki/JSONP#Security_concerns
Fixes: #2556
Ports: #4201