Optimize array access (#128)

* Manually optimize array access so it is fast even without LTO

* Format code

* Use sub on pointer, not NonNull

jl_sys/src/bindings.rs

@@ -1149,22 +1149,6 @@ extern "C" {
 
     pub fn jlrs_array_len(a: *mut crate::types::jl_array_t) -> usize;
 
-    #[cfg(any(
-        feature = "julia-1-6",
-        feature = "julia-1-7",
-        feature = "julia-1-8",
-        feature = "julia-1-9",
-        feature = "julia-1-10",
-    ))]
-    pub fn jlrs_array_data(a: *mut crate::types::jl_array_t) -> *mut std::ffi::c_void;
-
-    #[cfg(not(any(
-        feature = "julia-1-6",
-        feature = "julia-1-7",
-        feature = "julia-1-8",
-        feature = "julia-1-9",
-        feature = "julia-1-10",
-    )))]
     pub fn jlrs_array_data(a: *mut crate::types::jl_array_t) -> *mut std::ffi::c_void;
 
     pub fn jlrs_array_ndims(a: *mut crate::types::jl_array_t) -> usize;

jl_sys/src/jlrs_cc_reexport.h

@@ -20,12 +20,7 @@ extern "C"
     jl_value_t *jlrs_svecref(void *t, size_t i);          // X
     jl_value_t *jlrs_svecset(void *t, size_t i, void *x); // X
     size_t jlrs_array_len(jl_array_t *a);
-#if JULIA_VERSION_MINOR <= 10
     void *jlrs_array_data(jl_array_t *a);
-#endif
-#if JULIA_VERSION_MINOR >= 11
-    void *jlrs_array_data(jl_array_t *a);
-#endif
     size_t jlrs_array_ndims(jl_array_t *a);
     jl_value_t *jlrs_exprarg(jl_expr_t *e, size_t n);            // X
     void jlrs_exprargset(jl_expr_t *e, size_t n, jl_value_t *v); // X

jlrs/src/convert/into_julia.rs

@@ -45,12 +45,15 @@ use crate::{
 /// behavior. The type in Rust must always be `#[repr(C)]`. The `DataType` must be an isbits-type.
 ///
 /// [`Value::new`]: crate::data::managed::value::Value::new
-#[cfg_attr(feature = "diagnostics", diagnostic::on_unimplemented(
-    message = "the trait bound `{Self}: IntoJulia` is not satisfied",
-    label = "the trait `IntoJulia` is not implemented for `{Self}`",
-    note = "Custom types that implement `IntoJulia` should be generated with JlrsCore.reflect",
-    note = "Do not implement `ForeignType`, `OpaqueType`, or `ParametricVariant` unless this type is exported to Julia with `julia_module!`"
-))]
+#[cfg_attr(
+    feature = "diagnostics",
+    diagnostic::on_unimplemented(
+        message = "the trait bound `{Self}: IntoJulia` is not satisfied",
+        label = "the trait `IntoJulia` is not implemented for `{Self}`",
+        note = "Custom types that implement `IntoJulia` should be generated with JlrsCore.reflect",
+        note = "Do not implement `ForeignType`, `OpaqueType`, or `ParametricVariant` unless this type is exported to Julia with `julia_module!`"
+    )
+)]
 pub unsafe trait IntoJulia: Sized + 'static {
     /// Returns the associated Julia type of the implementor.
     ///

jlrs/src/convert/unbox.rs

@@ -48,12 +48,15 @@ use crate::data::managed::value::Value;
 ///
 /// [`Value::unbox`]: crate::data::managed::value::Value::unbox
 /// [`ValidLayout`]: crate::data::layout::valid_layout::ValidLayout
-#[cfg_attr(feature = "diagnostics", diagnostic::on_unimplemented(
-    message = "the trait bound `{Self}: Unbox` is not satisfied",
-    label = "the trait `Unbox` is not implemented for `{Self}`",
-    note = "Custom types that implement `Unbox` should be generated with JlrsCore.reflect",
-    note = "Do not implement `ForeignType`, `OpaqueType`, or `ParametricVariant` unless this type is exported to Julia with `julia_module!`"
-))]
+#[cfg_attr(
+    feature = "diagnostics",
+    diagnostic::on_unimplemented(
+        message = "the trait bound `{Self}: Unbox` is not satisfied",
+        label = "the trait `Unbox` is not implemented for `{Self}`",
+        note = "Custom types that implement `Unbox` should be generated with JlrsCore.reflect",
+        note = "Do not implement `ForeignType`, `OpaqueType`, or `ParametricVariant` unless this type is exported to Julia with `julia_module!`"
+    )
+)]
 pub unsafe trait Unbox {
     /// The type of the unboxed data. Must be `#[repr(C)]`.
     type Output: Sized + Clone;

jlrs/src/data/layout/valid_layout.rs

@@ -30,12 +30,15 @@ use crate::{
 /// Safety: implementations of [`ValidLayout::valid_layout`] must not trigger the GC. This means
 /// no function can be called that allocates Julia data, calls Julia functions, or can trigger the
 /// GC some other way.
-#[cfg_attr(feature = "diagnostics", diagnostic::on_unimplemented(
-    message = "the trait bound `{Self}: ValidLayout` is not satisfied",
-    label = "the trait `ValidLayout` is not implemented for `{Self}`",
-    note = "Custom types that implement `ValidLayout` should be generated with JlrsCore.reflect",
-    note = "Do not implement `ForeignType`, `OpaqueType`, or `ParametricVariant` unless this type is exported to Julia with `julia_module!`"
-))]
+#[cfg_attr(
+    feature = "diagnostics",
+    diagnostic::on_unimplemented(
+        message = "the trait bound `{Self}: ValidLayout` is not satisfied",
+        label = "the trait `ValidLayout` is not implemented for `{Self}`",
+        note = "Custom types that implement `ValidLayout` should be generated with JlrsCore.reflect",
+        note = "Do not implement `ForeignType`, `OpaqueType`, or `ParametricVariant` unless this type is exported to Julia with `julia_module!`"
+    )
+)]
 pub unsafe trait ValidLayout {
     /// Must be `true` if the Rust type is a managed type.
     const IS_REF: bool = false;