fix(vim): fix agent exit wrong type bug #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the vim plugin, whenever the tabby-agent exits (unexpectedly) the
s:tabby variable is set to `{}` instead of the numeric `0` to indicate
that the agent job is not running.
This leads to the agent functions trying to send messages anyway and
error messages being spammed for almost any editor event, for the wrong
variable type and subsequent errors, like:
```
line 8:
E731: using Dictionary as a String
line 12:
E474: Invalid argument
```
and
```
Error detected while processing BufLeave Autocommands for "*"... [...]
```
Setting the s:tabby variable to `0` on agent exit solves it.
|
@andreabak, Thank you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the vim plugin, whenever the tabby-agent exits (unexpectedly) the s:tabby variable is set to
{}instead of the numeric0to indicate that the agent job is not running.This leads to the agent functions trying to send messages anyway and error messages being spammed for almost any editor event, for the wrong variable type and subsequent errors, like:
and
Setting the s:tabby variable to
0on agent exit solves it.