feat: add Prometheus support to Tabby. #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Added `axum-prometheus` to Cargo.toml 2) Added `metrics.rs` as a simple route to produce a metrics endpoint with prometheus-formatted events 3) Added `/v1/metrics` endpoint with API doc entry 4) Added the `PrometheusLayer` to the root layers. This change effectively allows for external Prometheus to scrape metrics from Tabby during execution in order to monitor operations (resources, timings and overall usage).
wsxiaoys
requested changes
Nov 19, 2023
wsxiaoys
reviewed
Nov 19, 2023
# Conflicts: # crates/tabby/src/serve.rs
- Added Prometheus layer and handle to worker.rs
wsxiaoys
reviewed
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
axum-prometheusto Cargo.tomlAdded
metrics.rsas a simple route to produce a metrics endpoint with prometheus-formatted eventsAdded
/v1/metricsendpoint with API doc entryAdded the
PrometheusLayerto the root layers.This change effectively allows for external Prometheus to scrape metrics from Tabby during execution in order to monitor operations (resources, timings and overall usage).
Metrics can be viewed from the API docs and by calling
/v1/metricson a running instance.