-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(TMC-27581): security issue in redux storage decorator filter #5313
Merged
VolodymyrKovalM
merged 4 commits into
master
from
chore/TMC-27581/security-issue-in-redux-storage-decorator-filter
May 21, 2024
Merged
chore(TMC-27581): security issue in redux storage decorator filter #5313
VolodymyrKovalM
merged 4 commits into
master
from
chore/TMC-27581/security-issue-in-redux-storage-decorator-filter
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…curity-issue-in-redux-storage-decorator-filter
VolodymyrKovalM
temporarily deployed
to
pull_request_unsafe
May 21, 2024 08:18
— with
GitHub Actions
Inactive
VolodymyrKovalM
temporarily deployed
to
pull_request_unsafe
May 21, 2024 08:18
— with
GitHub Actions
Inactive
VolodymyrKovalM
temporarily deployed
to
pull_request_unsafe
May 21, 2024 08:18
— with
GitHub Actions
Inactive
VolodymyrKovalM
temporarily deployed
to
pull_request_unsafe
May 21, 2024 08:18
— with
GitHub Actions
Inactive
VolodymyrKovalM
temporarily deployed
to
pull_request_unsafe
May 21, 2024 08:18
— with
GitHub Actions
Inactive
Size Change: -273 kB (-2%) Total Size: 17.4 MB
ℹ️ View Unchanged
|
Gbacc
approved these changes
May 21, 2024
Maybe you will need a changeset ? |
VolodymyrKovalM
temporarily deployed
to
pull_request_unsafe
May 21, 2024 12:00
— with
GitHub Actions
Inactive
VolodymyrKovalM
temporarily deployed
to
pull_request_unsafe
May 21, 2024 12:00
— with
GitHub Actions
Inactive
VolodymyrKovalM
temporarily deployed
to
pull_request_unsafe
May 21, 2024 12:00
— with
GitHub Actions
Inactive
VolodymyrKovalM
temporarily deployed
to
pull_request_unsafe
May 21, 2024 12:00
— with
GitHub Actions
Inactive
VolodymyrKovalM
temporarily deployed
to
pull_request_unsafe
May 21, 2024 12:00
— with
GitHub Actions
Inactive
jmfrancois
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no more users of it so looks good to me.
If used it should have been a major but I will not bother you with that.
VolodymyrKovalM
temporarily deployed
to
pull_request_unsafe
May 21, 2024 12:44
— with
GitHub Actions
Inactive
VolodymyrKovalM
temporarily deployed
to
pull_request_unsafe
May 21, 2024 12:44
— with
GitHub Actions
Inactive
VolodymyrKovalM
temporarily deployed
to
pull_request_unsafe
May 21, 2024 12:44
— with
GitHub Actions
Inactive
VolodymyrKovalM
temporarily deployed
to
pull_request_unsafe
May 21, 2024 12:44
— with
GitHub Actions
Inactive
VolodymyrKovalM
temporarily deployed
to
pull_request_unsafe
May 21, 2024 12:44
— with
GitHub Actions
Inactive
VolodymyrKovalM
deleted the
chore/TMC-27581/security-issue-in-redux-storage-decorator-filter
branch
May 21, 2024 14:25
VolodymyrKovalM
had a problem deploying
to
pull_request_unsafe
May 21, 2024 14:25
— with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
Lodash per method packages are not maintained anymore, but still, lodash.set is used in "redux-storage-decorator-filter", which is used in TUI CMF
There is a security issue detected in lodash.set, and, since per method packages are not maintained, and "redux-storage-decorator-filter" seems also not maintained, we need to refactor CMF
https://jira.talendforge.org/browse/TMC-27581
What is the chosen solution to this problem?
As Redux storage functions in CMF are marked as deprecated, we can choose to refactor and remove this part
Looking through all Talend repositories, currently CMF Redux storage is used in
Semantic in ui-ee
ui-schema repository
ui-semantic repository (seems not maintained, has been moved to ui-ee repository, so, it is the same as Semantic in ui-ee)
Redux storage usage has been removed from Semantic in ui-ee in https://github.com/Talend/ui-ee/pull/1065
ui-schema repository, seems not used anywhere
So, seems Redux storage usage can be removed from CMF
Please check if the PR fulfills these requirements
yarn changeset
to a request a release from the CI if wanted.[ ] This PR introduces a breaking change