-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sagaRouter): upgrade path-to-regexp
#5480
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook for this PR deployed on this github page |
yyanwang
changed the title
fix(sagaRouter): update DOC and add unit test
fix(sagaRouter): optional route parameter
Dec 20, 2024
yyanwang
changed the title
fix(sagaRouter): optional route parameter
chore(sagaRouter): optional route parameter
Dec 20, 2024
yyanwang
had a problem deploying
to
pull_request_unsafe
December 24, 2024 10:29 — with
GitHub Actions
Error
yyanwang
changed the title
chore(sagaRouter): optional route parameter
chore(sagaRouter): upgrade Dec 24, 2024
path-to-regexp
yyanwang
temporarily deployed
to
pull_request_unsafe
December 24, 2024 10:30 — with
GitHub Actions
Inactive
jmfrancois
approved these changes
Dec 24, 2024
yyanwang
temporarily deployed
to
pull_request_unsafe
December 25, 2024 02:56 — with
GitHub Actions
Inactive
yyanwang
temporarily deployed
to
pull_request_unsafe
December 30, 2024 02:17 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
BREAKING CHANGE: Upgraded path-to-regexp from 3.x to 8.x
This upgrade was necessary to resolve security vulnerabilities. The new version introduces two breaking changes that require updates to your application:
/resources/:id?
/resources{/id}
This change is required because in path-to-regexp 8.x, the
?
character is reserved for query parameters and will throw a parsing error when used at the end of a path./
would match any path starting with/
/
only matches exactly/
/{*path}
Example migration:
For more details about path matching and troubleshooting, see path-to-regexp documentation.
What is the chosen solution to this problem?
Please check if the PR fulfills these requirements
yarn changeset
to a request a release from the CI if wanted.[ ] This PR introduces a breaking change