Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storybook): ie11 fix #928

Merged
merged 3 commits into from
Dec 26, 2017
Merged

fix(storybook): ie11 fix #928

merged 3 commits into from
Dec 26, 2017

Conversation

ncomont
Copy link
Contributor

@ncomont ncomont commented Dec 21, 2017

What is the problem this PR is trying to solve?

Storybook doesn't work on IE11. This is caused by a bug on the actions addon : storybookjs/storybook#2428

What is the chosen solution to this problem?

Upgrade dependencies

Please check if the PR fulfills these requirements

  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@ncomont ncomont merged commit 25ffb36 into master Dec 26, 2017
@ncomont ncomont deleted the ncomont/fix/storybook/ie11_fix branch December 26, 2017 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jare-talend jare-talend jare-talend approved these changes

@jsomsanith-tlnd jsomsanith-tlnd jsomsanith-tlnd approved these changes

Assignees
No one assigned
Labels
bug easy review need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncomont @build-travis-ci @jsomsanith-tlnd @jare-talend