fix: unmount field now updates form

* Add basic tests for arrays * Ran prettier * Ran prettier * Add new test for bug * Fix bug regarding preserved values even if field is umounted * Run prettier
TanStack · Nov 3, 2023 · 25a2fc8 · 25a2fc8
1 parent 6658947
commit 25a2fc8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/packages/form-core/src/FieldApi.ts b/packages/form-core/src/FieldApi.ts
@@ -243,6 +243,7 @@ export class FieldApi<
       unsubscribe()
       if (!preserveValue) {
         delete info.instances[this.uid]
+        this.form.deleteField(this.name)
       }
 
       if (!Object.keys(info.instances).length && !preserveValue) {

diff --git a/packages/form-core/src/tests/FieldApi.spec.ts b/packages/form-core/src/tests/FieldApi.spec.ts
@@ -601,5 +601,9 @@ describe('field api', () => {
     const info = form.getFieldInfo(field.name)
     expect(info.instances[field.uid]).toBeUndefined()
     expect(Object.keys(info.instances).length).toBe(0)
+
+    // Field should have been removed from the form as well
+    expect(form.state.values.name).toBeUndefined()
+    expect(form.state.fieldMeta.name).toBeUndefined()
   })
 })