Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot update a component/bad setState #420

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

GabrielModog
Copy link
Contributor

What this PR aims to:

  • fixes warning: "Cannot update a component while rendering a different component warning"

image

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 30, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change, but this looks good otherwise :)

packages/react-form/src/useForm.tsx Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Patch coverage is 100.00% of modified lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Files Changed Coverage
packages/react-form/src/useForm.tsx 100.00%

📢 Thoughts on this report? Let us know!.

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great stuff, thank you for the contribution!

@crutchcorn crutchcorn merged commit d8ff960 into TanStack:main Aug 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants