Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change form options spread to object assign #421

Conversation

GabrielModog
Copy link
Contributor

What this PR aims to:

  • Small improvement in the fieldOptions object: change Spread Operator to Object.assign.
    • with this even if receive anything that's not a object will not be appended 😎

@GabrielModog GabrielModog force-pushed the refactor/createFormFactory-fieldsOptions branch from 2038ca3 to 8a3e872 Compare August 31, 2023 20:25
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 31, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

Codecov Report

Patch coverage is 100.00% of modified lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Files Changed Coverage
packages/react-form/src/createFormFactory.ts 100.00%

📢 Thoughts on this report? Let us know!.

@crutchcorn crutchcorn merged commit 6eca66e into TanStack:main Sep 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants