Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(react-form): add on change validation tests #425

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

joaom00
Copy link
Contributor

@joaom00 joaom00 commented Sep 1, 2023

This PR creates a new file for useField related tests and adds the onChange validation tests along with a small test for the defaultValue there

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are amazing and give me so much more confidence in shipping. Sincerely, this is wonderful work - thank you!!

@crutchcorn crutchcorn merged commit 09edc1f into TanStack:main Sep 2, 2023
5 checks passed
@joaom00 joaom00 deleted the react-onchange-test branch September 2, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants