-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: solid.js form #471
feat: solid.js form #471
Conversation
This is incredible! Thank you! Are you up for a chat via Discord voice call by chance? Would love to walk through what potential next steps are and what edges of the code you'd like to look through! 😊 |
Sure! What's your username? |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
I'm taking over this here PR 🏴☠️🦜 Namely, I want to make sure we have:
And I feel guilty with how long this PR has been in the oven (my fault 100%). Gonna try to take your awesome effort and push it past the finish line tonight |
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
The Solid.js port of the form/core
Made all the options parameters functions to match how they are done in TanStack/query v5, that way reactive parameters don't require getters.
For Field, I had to do some finagling to register changes in the Field.store into Solid's reactivity. It makes the reactivity far less fine-grained than it could be since any change in the store would cause any effect subscribing to any unrelated field would still run. I was thinking of using a Proxy but the Field.store has many methods on them and I am unsure how to work on those.