Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: solid.js form #471

Merged
merged 15 commits into from
Oct 30, 2023
Merged

feat: solid.js form #471

merged 15 commits into from
Oct 30, 2023

Conversation

aadito123
Copy link
Member

The Solid.js port of the form/core

Made all the options parameters functions to match how they are done in TanStack/query v5, that way reactive parameters don't require getters.

For Field, I had to do some finagling to register changes in the Field.store into Solid's reactivity. It makes the reactivity far less fine-grained than it could be since any change in the store would cause any effect subscribing to any unrelated field would still run. I was thinking of using a Proxy but the Field.store has many methods on them and I am unsure how to work on those.

@crutchcorn
Copy link
Member

This is incredible! Thank you!

Are you up for a chat via Discord voice call by chance? Would love to walk through what potential next steps are and what edges of the code you'd like to look through! 😊

@aadito123
Copy link
Member Author

Sure! What's your username?

@crutchcorn crutchcorn self-requested a review October 9, 2023 09:17
packages/solid-form/src/createField.tsx Outdated Show resolved Hide resolved
packages/solid-form/src/createForm.tsx Outdated Show resolved Hide resolved
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 20, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@aadito123 aadito123 requested a review from crutchcorn October 24, 2023 02:47
@crutchcorn
Copy link
Member

I'm taking over this here PR 🏴‍☠️🦜

Namely, I want to make sure we have:

  • Updates to docs (even if they're just todos for now)
  • Examples
  • Adding to our deployment strategy so the new package gets published

And I feel guilty with how long this PR has been in the oven (my fault 100%). Gonna try to take your awesome effort and push it past the finish line tonight

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
packages/form-core/src/utils.ts 89.13% <ø> (ø)
packages/react-form/src/createFormFactory.ts 100.00% <100.00%> (ø)
packages/react-form/src/formContext.ts 83.33% <ø> (ø)
packages/react-form/src/useForm.tsx 88.88% <100.00%> (ø)
packages/solid-form/src/createFormFactory.ts 100.00% <100.00%> (ø)
packages/solid-form/src/tests/utils.ts 100.00% <100.00%> (ø)
packages/yup-form-adapter/src/tests/utils.ts 100.00% <100.00%> (ø)
packages/yup-form-adapter/src/validator.ts 100.00% <100.00%> (ø)
packages/zod-form-adapter/src/tests/utils.ts 100.00% <100.00%> (ø)
packages/zod-form-adapter/src/validator.ts 100.00% <100.00%> (ø)
... and 6 more

📢 Thoughts on this report? Let us know!.

@crutchcorn crutchcorn merged commit 6050fea into TanStack:main Oct 30, 2023
5 checks passed
@aadito123 aadito123 deleted the solid-form branch October 31, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants