-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add back form validation #493
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Still WIP. The validation logic for onChange and onBlur run but the form states are not updating as expected. Also need to implement the onMount validation. |
No worries @aadito123 - take your time 😄 Anything I can do to help? |
Per a convo with @aadito123 in DMs, we're deciding to add in a This allows us more flexibility in our future API development while also enabling Let's make sure we're updating our tests to reflect this change |
Feeling pretty confident in the implementation so far. Only had one test case though, so I want to add all the applicable validation test cases from the |
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
Migrated to PR #505 as I've somehow managed to break my ability to push to this PR |
@aadito123 took a stab at adding back form validation - ala #466 - this is that work tracked in a PR so I don't lose track of it