Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use updated publish.js script #540

Merged
merged 7 commits into from
Dec 31, 2023
Merged

chore: Use updated publish.js script #540

merged 7 commits into from
Dec 31, 2023

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Dec 31, 2023

  • Uses publish.js from here: https://github.com/TanStack/query/tree/main/scripts
  • Removed eslint-plugin-compat which broke when updating the script dependencies - this is no longer used in other repos as the tsup targets cover any transpiling required for our actual desired browsers

Copy link

codesandbox-ci bot commented Dec 31, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (c2f9957) 84.55% compared to head (5b2de29) 93.49%.
Report is 98 commits behind head on main.

Files Patch % Lines
packages/form-core/src/FormApi.ts 93.10% 8 Missing ⚠️
packages/form-core/src/FieldApi.ts 96.42% 3 Missing ⚠️
packages/form-core/src/utils.ts 96.07% 2 Missing ⚠️
packages/react-form/src/useField.tsx 75.00% 2 Missing ⚠️
packages/solid-form/src/createField.tsx 96.55% 1 Missing ⚠️
packages/solid-form/src/createForm.tsx 92.30% 1 Missing ⚠️
packages/solid-form/src/formContext.ts 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
+ Coverage   84.55%   93.49%   +8.94%     
==========================================
  Files           9       21      +12     
  Lines         395      646     +251     
  Branches      109      156      +47     
==========================================
+ Hits          334      604     +270     
+ Misses         52       39      -13     
+ Partials        9        3       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lachlancollins lachlancollins merged commit 2c3e848 into TanStack:main Dec 31, 2023
2 checks passed
@lachlancollins lachlancollins deleted the jsdoc-scripts branch December 31, 2023 00:26
lachlancollins added a commit that referenced this pull request Dec 31, 2023
* chore: Update CI versions of node and pnpm (#538)

* Update node and pnpm for CI

* Update concurrency and run conditions

* docs(CONTRIBUTING.md): add instructions for previewing the docs locally (#537)

* chore: Update to Nx v17 (#539)

* Update CI run condition

* Update to Nx v17

* Attempt to fix scripts

* Fully utilise Nx for PR workflow

* chore: Use updated `publish.js` script (#540)

* Initial rename and copy

* Update relevant packages

* Remove ts-node

* Mark root as ESM

* Move getTsupConfig

* Remove eslint-plugin-compat

* Make codesandbox run Node 18

* chore: Add missing command to CI workflow (#541)

* chore: Enable Nx distributed caching (#542)

* chore: Update prettier config (#543)

* Update prettier config

* Run format

* Update gitignore

---------

Co-authored-by: fuko <43729152+fulopkovacs@users.noreply.github.com>
crutchcorn added a commit that referenced this pull request Dec 31, 2023
* docs: add initial NextJS RSC code sample

* chore: replace react imports with rehackt imports

#480 (comment)

* chore: initial work to add server action support to React Form

* feat: got initial demo of NextJS server action error to work

* feat: add useTransform and mergeForm APIs

* chore: WIP

* feat: add transform array checking

* fix: issues with canSubmit state issues when using server validation

* fix: remove error when Field component is first ran

* fix: correct failing tests

* chore: fix ci/cd

* chore: fix next server action typings

* chore: fix various issues with templates and CI/CD

* chore: upgrade node version

* chore: change from tsup to manual rollup

* Revert "chore: change from tsup to manual rollup"

This reverts commit 994c85c.

* chore: attempt to fix tsup issues

* Revert "chore: attempt to fix tsup issues"

This reverts commit b9b1f07.

* chore: migrate form-core to use Vite

* chore: migrate Vue package to Vite

* docs: migrate form adapters to vite

* chore: migrate solid and react packages to use vite

* chore: refactor to single config generator

* chore: remove typescript 4.8

* chore: fix issues with test ci

* chore: fix PR CI

* chore: fix clean script

* Merge main into nextjs-server-actions (#545)

* chore: Update CI versions of node and pnpm (#538)

* Update node and pnpm for CI

* Update concurrency and run conditions

* docs(CONTRIBUTING.md): add instructions for previewing the docs locally (#537)

* chore: Update to Nx v17 (#539)

* Update CI run condition

* Update to Nx v17

* Attempt to fix scripts

* Fully utilise Nx for PR workflow

* chore: Use updated `publish.js` script (#540)

* Initial rename and copy

* Update relevant packages

* Remove ts-node

* Mark root as ESM

* Move getTsupConfig

* Remove eslint-plugin-compat

* Make codesandbox run Node 18

* chore: Add missing command to CI workflow (#541)

* chore: Enable Nx distributed caching (#542)

* chore: Update prettier config (#543)

* Update prettier config

* Run format

* Update gitignore

---------

Co-authored-by: fuko <43729152+fulopkovacs@users.noreply.github.com>

* Fix lockfile

---------

Co-authored-by: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com>
Co-authored-by: fuko <43729152+fulopkovacs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants