Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The devtools logo does not display the default value of the buttonPosition prop correctly. #6242

Closed
phatpcdev opened this issue Oct 25, 2023 · 2 comments · Fixed by #6720
Closed
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@phatpcdev
Copy link

Describe the bug

The bug occurs when I show devtools with default options. Specifically, the default value of buttonPosition is bottom-left (docs: https://tanstack.com/query/v5/docs/react/devtools), but actually I see the logo at bottom-right corner on my screen.

Maybe this problem is from line 91 in file https://github.com/TanStack/query/blob/main/packages/query-devtools/src/Devtools.tsx

I hope my report will help the TanStack team fix the bug faster. Thanks.

Your minimal, reproducible example

https://codesandbox.io/s/green-field-l6q7pw

Steps to reproduce

https://codesandbox.io/s/green-field-l6q7pw

Expected behavior

Expected: The logo will display as the documentation describes

How often does this bug happen?

None

Screenshots or Videos

No response

Platform

  • Version: Query devtools v5.1.0

Tanstack Query adapter

None

TanStack Query version

v5.0.5

TypeScript version

No response

Additional context

No response

@ardeora ardeora added the documentation Improvements or additions to documentation label Oct 25, 2023
@ardeora
Copy link
Contributor

ardeora commented Oct 25, 2023

Thanks for creating this issue! Yeah the docs are erroneous. The default position of the new devtools button should be on the bottom-right. I'll fix the documentation for all the adapters. You can still change the button position by by passing the buttonPosition prop to the devtools component if you'd like.

@ardeora ardeora self-assigned this Oct 25, 2023
@phatpcdev
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants