Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-devtools): Update default devtools button position to bottom-right 🌱 #6720

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

agustints
Copy link
Contributor

Summary

This pull request addresses a comment from the maintainers regarding the default position of the query devtools. The change aligns the default devtools position with the bottom-right corner to maintain consistency between adapters and documentation.

Changes Made

Updated the default position of the query devtools to bottom-right.
Adjusted relevant documentation to reflect the updated default position.

Context

The maintainers suggested aligning the default devtools position with the bottom-right corner to maintain consistency across adapters and documentation. This adjustment ensures a unified experience for users and developers using the query library.

Related Issues

Closes #6242
Screenshot 2024-01-16 at 16 14 36

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2024 2:04am

@agustints agustints changed the title Fix: Update default devtools position to bottom-right 🌱 Fix: Update default devtools button position to bottom-right 🌱 Jan 16, 2024
Copy link

codesandbox-ci bot commented Jan 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1531207:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration
frosty-tom-s57r53 Issue #6242
prod-forest-8k4rrl Issue #6242

@agustints agustints changed the title Fix: Update default devtools button position to bottom-right 🌱 fix(query-devtools): Update default devtools button position to bottom-right 🌱 Jan 16, 2024
@arnoud-dv
Copy link
Collaborator

arnoud-dv commented Jan 17, 2024

I was just working on the Angular devtools and fixed this in there. Sorry for the conflict.

Noticed that default seems to have changed for position as well: it is mentioned the default is bottom but it's shown at the right when nothing is set.

@agustints
Copy link
Contributor Author

agustints commented Jan 17, 2024

Hi @arnoud-dv, awesome thanks for fixing it for Angular, I updated the branch and fixed the conflicts 👌
Also checked the position attribute and it's working well defaults to bottom 👍

Copy link

nx-cloud bot commented Jan 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1531207. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@DamianOsipiuk DamianOsipiuk merged commit 21dc729 into TanStack:main Jan 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The devtools logo does not display the default value of the buttonPosition prop correctly.
3 participants