Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent redundant renders #1487

Merged
merged 1 commit into from
Dec 19, 2020

Conversation

boschni
Copy link
Collaborator

@boschni boschni commented Dec 19, 2020

With the change in #1449 components will always render the latest result instead of waiting for an update from the QueryObserver. This means that in some cases, the update is redundant because it has already been rendered. This PR will prevent those redundant renders.

Might fix: #1482

@vercel
Copy link

vercel bot commented Dec 19, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/pws45bhu5
✅ Preview: https://react-query-git-feature-prevent-redundant-renders.tannerlinsley.vercel.app

@tannerlinsley tannerlinsley merged commit bffdc0e into master Dec 19, 2020
@tannerlinsley tannerlinsley deleted the feature/prevent-redundant-renders branch December 19, 2020 10:29
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3.2 => v3.3 regression] v3.3 breaks concurrent mode
2 participants