Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): revert docs for QueryCache #5221

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

judicaelandria
Copy link
Contributor

This PR revert the docs for QueryCache
from

find({queryKey: QueryKey})

to

find(queryKey)

@nx-cloud
Copy link

nx-cloud bot commented Apr 2, 2023

@vercel
Copy link

vercel bot commented Apr 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Apr 2, 2023 5:21pm

@judicaelandria
Copy link
Contributor Author

closes #5177

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 461d0fb:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 2, 2023

Can you please also make a PR that re-introduces the changes against the alpha branch (v5)

@TkDodo TkDodo merged commit 1c5165e into TanStack:main Apr 2, 2023
@judicaelandria judicaelandria deleted the feat/revert-docs branch April 2, 2023 17:56
@judicaelandria
Copy link
Contributor Author

Can you please also make a PR that re-introduces the changes against the alpha branch (v5)

but the alpha branch already have that change?

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 2, 2023

if we merge main back into alpha, which we do regularly, it won't have the change anymore because this PR will overwrite it I think ?

@judicaelandria
Copy link
Contributor Author

yes! if it's overwritten I'll send a pr to re-introduce the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants