Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Fix-5538]: Assign observer's current Result when optimistic read occurs" #5840

Closed
wants to merge 1 commit into from

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Aug 4, 2023

Reverts #5573

fixes #5719

@incepter FYI

@vercel
Copy link

vercel bot commented Aug 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
query ⬜️ Ignored (Inspect) Aug 4, 2023 8:54pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0547926:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@nx-cloud
Copy link

nx-cloud bot commented Aug 4, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0547926. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +2.67% 🎉

Comparison is base (88bd699) 89.13% compared to head (0547926) 91.80%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5840      +/-   ##
==========================================
+ Coverage   89.13%   91.80%   +2.67%     
==========================================
  Files          13      101      +88     
  Lines         681     3918    +3237     
  Branches      240      986     +746     
==========================================
+ Hits          607     3597    +2990     
- Misses         68      300     +232     
- Partials        6       21      +15     
Files Changed Coverage Δ
packages/query-core/src/queryObserver.ts 84.08% <0.00%> (ø)

... and 87 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TkDodo TkDodo closed this Aug 4, 2023
@lachlancollins lachlancollins deleted the revert-5573-fix-data-double-ref branch July 26, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite render loop with v4.29.{22,23}
2 participants