Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use Node 20 for CodeSandbox examples #7646

Merged
merged 6 commits into from
Jun 29, 2024
Merged

ci: Use Node 20 for CodeSandbox examples #7646

merged 6 commits into from
Jun 29, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Jun 29, 2024

  • Seems like CodeSandbox has added a Node 20 option (v20.12.2), but just hasn't documented it
  • It's also enabled corepack by default, meaning we don't need a custom pnpm install script anymore
  • The previous Node 18 version (v18.12.1) was incompatible with new versions of Next.js

Copy link

vercel bot commented Jun 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Jun 29, 2024 6:14am

Copy link

nx-cloud bot commented Jun 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4302188. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codesandbox-ci bot commented Jun 29, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4302188:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@lachlancollins lachlancollins changed the title ci: Try to use Node 20 for CSB ci: Use Node 20 for CodeSandbox examples Jun 29, 2024
@lachlancollins lachlancollins marked this pull request as ready for review June 29, 2024 06:19
@lachlancollins lachlancollins merged commit 033e739 into main Jun 29, 2024
6 checks passed
@lachlancollins lachlancollins deleted the csb-node-20 branch June 29, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant