fix(query-core): type override subscribe in InfiniteQueryObserver more clearly #7914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manudeli
changed the title
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ccb4a62. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
|
commit: @tanstack/angular-query-devtools-experimental
@tanstack/angular-query-experimental
@tanstack/eslint-plugin-query
@tanstack/query-async-storage-persister
@tanstack/query-broadcast-client-experimental
@tanstack/query-core
@tanstack/query-devtools
@tanstack/query-persist-client-core
@tanstack/query-sync-storage-persister
@tanstack/react-query
@tanstack/react-query-devtools
@tanstack/react-query-next-experimental
@tanstack/react-query-persist-client
@tanstack/solid-query
@tanstack/solid-query-devtools
@tanstack/solid-query-persist-client
@tanstack/svelte-query
@tanstack/svelte-query-devtools
@tanstack/svelte-query-persist-client
@tanstack/vue-query
@tanstack/vue-query-devtools
More templates
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7914 +/- ##
===========================================
+ Coverage 44.64% 63.29% +18.65%
===========================================
Files 187 127 -60
Lines 7090 4536 -2554
Branches 1575 1264 -311
===========================================
- Hits 3165 2871 -294
+ Misses 3562 1437 -2125
+ Partials 363 228 -135 |
manudeli
commented
Aug 18, 2024
Comment on lines
+42
to
+44
| subscribe!: Subscribable< | ||
| InfiniteQueryObserverListener<TData, TError> | ||
| >['subscribe'] |
There was a problem hiding this comment.
It's trivial. but when doing type overriding, I want to use Subscribable and make it clearer to override while keeping the constraints of Subscribable, so I think it reduces the possibility of making constraint mistakes.
There was a problem hiding this comment.
shouldn't we do the same for other type overrides, like fetch a couple of lines below as well?
There was a problem hiding this comment.
I tried this on other type overrides(getCurrentResult, fetch) in ccb4a62
manudeli
commented
Aug 19, 2024
Comment on lines
+42
to
+44
| subscribe!: Subscribable< | ||
| InfiniteQueryObserverListener<TData, TError> | ||
| >['subscribe'] |
There was a problem hiding this comment.
I tried this on other type overrides(getCurrentResult, fetch) in ccb4a62
TkDodo
approved these changes
Aug 19, 2024
This was referenced Sep 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.