fix(eslint-plugin-query): relax property order rule to ignore relative order of getPreviousPageParam and getNextPageParam #8074

schiller-manuel · 2024-09-20T21:32:59Z

No description provided.

nx-cloud · 2024-09-20T21:33:21Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e7545cd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

pkg-pr-new · 2024-09-20T21:34:48Z

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8074

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8074

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8074

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8074

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8074

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8074

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8074

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8074

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8074

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8074

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8074

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8074

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8074

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8074

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8074

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8074

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8074

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8074

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8074

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8074

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8074

commit: e7545cd

…e order of getPreviousPageParam and getNextPageParam

codecov · 2024-09-21T08:16:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.89%. Comparing base (f8d65fb) to head (e7545cd).
Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #8074       +/-   ##
===========================================
+ Coverage   44.97%   84.89%   +39.92%     
===========================================
  Files         199       15      -184     
  Lines        7362      490     -6872     
  Branches     1660      181     -1479     
===========================================
- Hits         3311      416     -2895     
+ Misses       3674       57     -3617     
+ Partials      377       17      -360

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`∅ <ø> (∅)`
@tanstack/eslint-plugin-query	`84.89% <100.00%> (-2.26%)`	⬇️
@tanstack/query-async-storage-persister	`∅ <ø> (∅)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`∅ <ø> (∅)`
@tanstack/query-devtools	`∅ <ø> (∅)`
@tanstack/query-persist-client-core	`∅ <ø> (∅)`
@tanstack/query-sync-storage-persister	`∅ <ø> (∅)`
@tanstack/react-query	`∅ <ø> (∅)`
@tanstack/react-query-devtools	`∅ <ø> (∅)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`∅ <ø> (∅)`
@tanstack/solid-query	`∅ <ø> (∅)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`∅ <ø> (∅)`
@tanstack/svelte-query	`∅ <ø> (∅)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`∅ <ø> (∅)`
@tanstack/vue-query	`∅ <ø> (∅)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

Semigradsky · 2024-09-23T06:38:39Z

@schiller-manuel In v5.57.1 I see the error:

Oops! Something went wrong! :(

ESLint: 8.57.0

Error: Unsupported spread element
Occurred while linting /.../index.tsx:27
Rule: "@tanstack/query/infinite-query-property-order"
    at /home/dmitry/P/mp-web/node_modules/@tanstack/eslint-plugin-query/dist/cjs/rules/infinite-query-property-order/infinite-query-property-order.rule.cjs:55:21
    at Array.flatMap (<anonymous>)
    at Object.CallExpression (/home/dmitry/P/mp-web/node_modules/@tanstack/eslint-plugin-query/dist/cjs/rules/infinite-query-property-order/infinite-query-property-order.rule.cjs:48:42)
    at enhancedRuleInstructions.<computed> (/home/dmitry/P/mp-web/node_modules/@tanstack/eslint-plugin-query/dist/cjs/utils/detect-react-query-imports.cjs:44:77)
    at ruleErrorHandler (/home/dmitry/P/mp-web/node_modules/eslint/lib/linter/linter.js:1076:28)
    at /home/dmitry/P/mp-web/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/home/dmitry/P/mp-web/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/home/dmitry/P/mp-web/node_modules/eslint/lib/linter/node-event-generator.js:297:26)
    at NodeEventGenerator.applySelectors (/home/dmitry/P/mp-web/node_modules/eslint/lib/linter/node-event-generator.js:326:22)

Previous version (5.56.1) works great.

The code is like this:

    const { data, isFetching, isLoading, hasNextPage, fetchNextPage } =
      useInfiniteQuery({
        ...communitiesQuery({
          filters: {
            ...fieldValues,
            placementFormats: ........,
          },
        }),
        refetchOnMount: false,
      })
      ```

github-actions bot added the package: eslint-plugin-query label Sep 20, 2024

schiller-manuel force-pushed the fix-eslint-relax branch from 1c0cfd6 to 074dc30 Compare September 20, 2024 21:35

fix(eslint-plugin-query): relax property order rule to ignore relativ…

e7545cd

…e order of getPreviousPageParam and getNextPageParam

schiller-manuel force-pushed the fix-eslint-relax branch from 074dc30 to e7545cd Compare September 21, 2024 08:14

TkDodo approved these changes Sep 21, 2024

View reviewed changes

TkDodo merged commit 1793e06 into TanStack:main Sep 21, 2024
8 checks passed

schiller-manuel mentioned this pull request Sep 23, 2024

fix(eslint-plugin-query): correctly handle call-expression spread #8090

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin-query): relax property order rule to ignore relative order of getPreviousPageParam and getNextPageParam #8074

fix(eslint-plugin-query): relax property order rule to ignore relative order of getPreviousPageParam and getNextPageParam #8074

schiller-manuel commented Sep 20, 2024

nx-cloud bot commented Sep 20, 2024 •

edited

Loading

pkg-pr-new bot commented Sep 20, 2024 •

edited

Loading

codecov bot commented Sep 21, 2024 •

edited

Loading

Semigradsky commented Sep 23, 2024

fix(eslint-plugin-query): relax property order rule to ignore relative order of getPreviousPageParam and getNextPageParam #8074

fix(eslint-plugin-query): relax property order rule to ignore relative order of getPreviousPageParam and getNextPageParam #8074

Conversation

schiller-manuel commented Sep 20, 2024

nx-cloud bot commented Sep 20, 2024 • edited Loading

☁️ Nx Cloud Report

pkg-pr-new bot commented Sep 20, 2024 • edited Loading

codecov bot commented Sep 21, 2024 • edited Loading

Codecov Report

Semigradsky commented Sep 23, 2024

nx-cloud bot commented Sep 20, 2024 •

edited

Loading

pkg-pr-new bot commented Sep 20, 2024 •

edited

Loading

codecov bot commented Sep 21, 2024 •

edited

Loading