fix: make router-generator a peer dep of react-router (#2278)

type tests of generated code must be implemented in a separate package to break up this circular dependency
TanStack · Sep 6, 2024 · ef95a05 · ef95a05
1 parent 5fa21ad
commit ef95a05
Show file tree

Hide file tree

Showing 16 changed files with 15 additions and 2,793 deletions.
diff --git a/.gitignore b/.gitignore
@@ -20,6 +20,9 @@ coverage
 *.tgz
 .wrangler
 
+# tests
+packages/router-generator/tests/**/*.gen.ts
+
 # misc
 .DS_Store
 .env

diff --git a/packages/react-router/package.json b/packages/react-router/package.json
@@ -80,6 +80,12 @@
   },
   "peerDependencies": {
     "react": ">=18",
-    "react-dom": ">=18"
+    "react-dom": ">=18",
+    "@tanstack/router-generator": "workspace:*"
+  },
+  "peerDependenciesMeta": {
+    "@tanstack/react-router": {
+      "optional": true
+    }
   }
 }
diff --git a/packages/router-generator/package.json b/packages/router-generator/package.json
@@ -67,8 +67,5 @@
     "tsx": "^4.19.0",
     "prettier": "^3.3.3",
     "zod": "^3.23.8"
-  },
-  "devDependencies": {
-    "@tanstack/react-router": "^1.53.1"
   }
 }
diff --git a/packages/router-generator/tests/generator/append-and-prepend/routeTree.gen.ts b/packages/router-generator/tests/generator/append-and-prepend/routeTree.gen.ts