Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-router): make sure full matches are passed into route functions #3039

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

schiller-manuel
Copy link
Contributor

fixes #2995

Copy link

nx-cloud bot commented Dec 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e5809d5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Dec 19, 2024

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3039

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3039

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3039

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3039

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3039

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3039

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3039

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3039

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3039

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3039

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3039

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3039

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3039

@tanstack/start-vite-plugin

npm i https://pkg.pr.new/@tanstack/start-vite-plugin@3039

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3039

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3039

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3039

commit: e5809d5

@schiller-manuel schiller-manuel changed the title fix(react-router): ensure that meta/links/scripts/headers are executed after match resolves fix(react-router): make sure full matches are passed into route functions Dec 19, 2024
@schiller-manuel schiller-manuel merged commit 347544c into main Dec 19, 2024
5 checks passed
@schiller-manuel schiller-manuel deleted the fix-2995 branch December 19, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createRootRoute head() only called once during pre-render w/out matches, breaking route-level <head> changes
2 participants