-
-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(start): returning null
from server functions
#3048
Merged
SeanCassiere
merged 18 commits into
TanStack:main
from
alakhpc:fix-serverfn-null-return
Dec 22, 2024
Merged
fix(start): returning null
from server functions
#3048
SeanCassiere
merged 18 commits into
TanStack:main
from
alakhpc:fix-serverfn-null-return
Dec 22, 2024
+106
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can you please cherry-pick this on top? #2778 |
This comment was marked as outdated.
This comment was marked as outdated.
View your CI Pipeline Execution ↗ for commit 9f7645d.
☁️ Nx Cloud last updated this comment at |
e2e/start/basic/app/routes/-server-fns/allow-fn-return-null.tsx
Outdated
Show resolved
Hide resolved
SeanCassiere
approved these changes
Dec 22, 2024
SeanCassiere
changed the title
Fix returning null from serverfns
fix(start): returning Dec 22, 2024
null
from server functions
@alakhpc thank you for contributing this fix 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2776, pass through null returns from serverfns