-
-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(react-router): expose scrollBehavior
on the ScrollRestoration
component
#3053
refactor(react-router): expose scrollBehavior
on the ScrollRestoration
component
#3053
Conversation
View your CI Pipeline Execution ↗ for commit 8d03040.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshuaKnauber looks like your changing of the import ordering in the packages/react-router/src/scroll-restoration.tsx
file has broken eslint. Please use the eslint suggestions and fix the ordering.
please update docs docs/framework/react/guide/scroll-restoration.md |
scrollBehavior
on the ScrollRestoration
component
scrollBehavior
on the ScrollRestoration
componentscrollBehavior
on the ScrollRestoration
component
@joshuaKnauber thank you for contributing this in 🎉 |
Thank you for reviewing and for all your guys work! |
Exposes the scroll behavior option for the ScrollRestoration component.
Currently the scrollTo only receives the x and y which makes it animate smoothly. If we always want to force an instant jump to the last point we should be able to set the behavior.