Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-virtual): add missing react-dom peer dependencies #613

Merged
merged 1 commit into from
Oct 21, 2023
Merged

fix(react-virtual): add missing react-dom peer dependencies #613

merged 1 commit into from
Oct 21, 2023

Conversation

piecyk
Copy link
Collaborator

@piecyk piecyk commented Oct 21, 2023

closes #612

@piecyk piecyk merged commit c940b9e into TanStack:beta Oct 21, 2023
2 checks passed
@piecyk piecyk deleted the fix/react-dom-peer-dependencies branch October 21, 2023 11:10
@simPod
Copy link

simPod commented Oct 21, 2023

thanks. can we publish the release to npm?

@piecyk
Copy link
Collaborator Author

piecyk commented Oct 21, 2023

thanks. can we publish the release to npm?

Yes, it’s already there.

@simPod
Copy link

simPod commented Oct 21, 2023

Can you recheck?

image

https://www.npmjs.com/package/@tanstack/react-virtual

@piecyk
Copy link
Collaborator Author

piecyk commented Oct 21, 2023

Ooo looks like something went wrong while auto publishing 😞

@piecyk
Copy link
Collaborator Author

piecyk commented Oct 22, 2023

@simPod checkout the 3.0.0-beta.68

@simPod
Copy link

simPod commented Oct 22, 2023

CI is green now thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting Can't resolve 'react-dom' since v3.0.0-beta.66 with yarnpnp
2 participants
@piecyk @simPod