Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues to improve the print output #1723

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

vekunz
Copy link
Contributor

@vekunz vekunz commented Apr 14, 2022

I fixed some issues with the print output that some elements were not hidden in print mode.


In addition to the issues, I fixed there is another issue, I could not fix. In print mode, the border around the portions selector should disappear. Currently, this is not possible, because in tandoor.min.css on line 10444 is this style, and the !important makes it impossible, to override this from inside a component (because the CSS selector is very strong):

textarea, input:not([type="submit"]):not([class="multiselect__input"]):not([class="select2-search__field"]):not([class="vue-treeselect__input"]), select  {
    background-color: white !important;
    border-radius: .25rem !important;
    border: 1px solid #ced4da !important;
}

Since I do not know what the overall effect of removing the !important is, I left it there.


This is my first contribution and I hope that I have done it properly.

@vabene1111
Copy link
Collaborator

Thank you very much for the contribution and well structured comments.

@Kaibu do you know if the important is required?

@Ashish8684
Copy link

Nice sir

@Kaibu
Copy link
Collaborator

Kaibu commented Apr 18, 2022

Looking into it

@vabene1111 vabene1111 added this to the 1.3.0 milestone May 11, 2022
@vabene1111
Copy link
Collaborator

will get this merged for now and open an issue for the other point you mentioned for me to review later

@vabene1111 vabene1111 merged commit af1282c into TandoorRecipes:develop Jun 14, 2022
@vekunz vekunz deleted the feature/optimize_printing branch June 15, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants