Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clickable keywords to recipe card #1731

Conversation

parkroland
Copy link
Contributor

@parkroland parkroland commented Apr 18, 2022

This is a quick change to the Recipe Card styling to resolve #1287. This is my first open source pull request ever so forgive me for my lack of knowledge hahaha.

@vabene1111
Copy link
Collaborator

oh this is cool, i did not know that it was this easy to fix it but it makes total sense, thanks for your contribution, saved my a lot of time.

Also congrats to your first PR, you did everything correctly, even linking the issue which is awesome!
If you want to be extra awesome in the future many maintainers love to quickly get an overview of what was changed so a short explanation of the changes is often welcome (although this change was very easy to understand in the code so it is perfectly fine the way you did it, just for more complex stuff)

@vabene1111 vabene1111 merged commit 2fdd9ed into TandoorRecipes:develop Apr 18, 2022
@parkroland
Copy link
Contributor Author

Sounds good thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

click on keywords
2 participants