Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docker run speeds #3055

Merged
merged 6 commits into from
Apr 4, 2024
Merged

Conversation

tooboredtocode
Copy link
Contributor

Alters the docker image and boot script so that static files are collected ahead of time. This massively speeds up the start up as now this step is simply copying the already collected files.

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2024

CLA assistant check
All committers have signed the CLA.

boot.sh Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
boot.sh Outdated Show resolved Hide resolved
@tooboredtocode
Copy link
Contributor Author

@vabene1111 the removal of venv was reverted, i will open another PR for this change though once this is merged though, where this can be discussed more thoroughly

@tooboredtocode
Copy link
Contributor Author

Hi, will this ever be merged?

@vabene1111
Copy link
Collaborator

approving something usually means that I will merge it but since there are literally endless things to do I will do everything whenever I feel like its right to do it. So please have some patience, since this is a non critical change.

Apart from that thank you very much for your contribution.

@vabene1111 vabene1111 merged commit d766927 into TandoorRecipes:develop Apr 4, 2024
1 check passed
vabene1111 added a commit that referenced this pull request Apr 8, 2024
This reverts commit d766927, reversing
changes made to 4293ec7.
@vabene1111
Copy link
Collaborator

reverted this PR as it lead to errors on certain setups. #3099

can merge it again if plausible reason and solution is found. Otherwise we will just live with a little slower startup for now, can look into build/setup optimizations again for vue3 version.

tooboredtocode added a commit to tooboredtocode/tandoor that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants