Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3060 Next Cloud handle special ingredients ## #3121

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

ellezhu1
Copy link
Contributor

Fix #3060

Before and After:

nextCloudBefore1
nextCloudAfter

@vabene1111
Copy link
Collaborator

thanks for the RP, two ideas:

  1. should we use .startwith() to make sure lines that just contain a double ## somehwere are not ignored
  2. what do you think of instead of ignoring the lines adding them as a header in tandoor (by setting is_header to true on the ingredient and setting the text (without the ##) into the note field (leaving food/unit None and amount 0)

@ellezhu1
Copy link
Contributor Author

  1. I didn't think it was very likely; however, you make a good point. I have gone ahead and changed it to use .startswith()
  2. I did consider making them into subheaders but I couldn't figure out how to do it. Your tip about the note field was very helpful. I have now implemented the lines as headers.

Thanks for the feedback!

@vabene1111
Copy link
Collaborator

perfect, thank you. Will get both PR's merged for the next release.

@vabene1111 vabene1111 merged commit 717c989 into TandoorRecipes:develop Apr 22, 2024
1 check passed
@ellezhu1 ellezhu1 deleted the nextCloud branch April 22, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nextcloud Importer handle special ingredients ##
2 participants