Fix Paprika Import Images when not downloading from URL. #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the code only tried to use the cropped image from paprika when downloading actively failed. But if a user takes an image himself, the url will be empty, thus downloading won't be attempted and won't fail. This change makes it so that the download is tried first, but the photo_data is always tried if no image exists for whatever reason.
|
|
|
awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code only tried to use the cropped image from paprika when downloading was attempted and actively failed. But if a user takes an image himself, the url field will be empty, thus downloading won't be attempted and won't fail.
This resulted in no image being imported at all.
This change makes it so that the download is tried first, but the
photo_datais always tried if no image exists after, for whatever reason.