Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when selecting items using the keyboard.
Bug
To replicate the bug on the demo app of the current release:
Explanation
The navigation controller does not remove the previously set
navigate
keydown listener after the reset. On keydown, only the first listener added updates itscurrentFocus
or selects the item. This causes the navigation to use the wrong index on selection with the keyboard after the list is reset.Fix
Remove previous keydown listener on navigation init.
Notes
I wasn't sure how to reference the previous handler function. I attached it to the
inputField
under a rather descriptive property.