Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closure doesn't support ECMASCRIPT6/ECMASCRIPT6_STRICT on remote plugin #52

Closed
minimonsters opened this issue Sep 9, 2021 · 2 comments
Closed

Closure doesn't support ECMASCRIPT6/ECMASCRIPT6_STRICT on remote plugin #52

minimonsters opened this issue Sep 9, 2021 · 2 comments

Comments

@minimonsters
Copy link

The optional request parameters for the API support ecmascript6 tags, but the library seems to enforce its own type checking on this field and only allows up to ecmascript5 to work

I would suggest, for future-proofing, that you let google tell us that the language variable supplied is invalid (same with any other variables)

Thank you for providing this library!

https://developers.google.com/closure/compiler/docs/api-ref#opt
@minimonsters minimonsters changed the title Closure doesn't support ECMASCRIPT6/ECMASCRIPT6STRICT on remote plugin Closure doesn't support ECMASCRIPT6/ECMASCRIPT6_STRICT on remote plugin Sep 9, 2021
@Taritsyn
Copy link
Owner

Thanks for information!

Taritsyn added a commit that referenced this issue Sep 10, 2021
@Taritsyn
In BundleTransformer.Closure fixed a error #52 “Closure doesn't suppo…
92cfcfe 
…rt ECMASCRIPT6/ECMASCRIPT6_STRICT on remote plugin”
@Taritsyn
Copy link
Owner

This problem has been fixed in version 1.12.39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Taritsyn @minimonsters