Skip to content

Commit

Permalink
Remove MsWheaEarlyUnitTestApp from Q35 and SBSA
Browse files Browse the repository at this point in the history
Description

Remove the failure exemption and test from the Q35 and SBSA platform
DSC files. The test is removed from Q35 because the CMOS emulated size
is too small to store WHEA records and from SBSA because no early
store option currently exists on ARM platforms.

- [ ] Impacts functionality?
  - **Functionality** - Does the change ultimately impact how firmware functions?
  - Examples: Add a new library, publish a new PPI, update an algorithm, ...
- [ ] Impacts security?
  - **Security** - Does the change have a direct security impact on an application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
  - **Breaking change** - Will anyone consuming this change experience a break
    in build or boot behavior?
  - Examples: Add a new library class, move a module to a different repo, call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
  - **Documentation** - Does the change contain explicit documentation additions
    outside direct code modifications (and comments)?
  - Examples: Update readme file, add feature readme file, link to documentation
    on an a separate Web page, ...

How This Was Tested

N/A

Integration Instructions

N/A
  • Loading branch information
TaylorBeebe committed May 5, 2023
1 parent 03e3222 commit 7453bf9
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
1 change: 0 additions & 1 deletion Platforms/QemuQ35Pkg/PlatformBuild.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
FAILURE_EXEMPT_TESTS = {
"BootAuditTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0),
"LineParserTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0),
"MsWheaEarlyUnitTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0),
"VariablePolicyFuncTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0),
"DeviceIdTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0),
"DxePagingAuditTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0),
Expand Down
5 changes: 4 additions & 1 deletion Platforms/QemuQ35Pkg/QemuQ35Pkg.dsc
Original file line number Diff line number Diff line change
Expand Up @@ -792,6 +792,9 @@
gUefiQemuQ35PkgTokenSpaceGuid.PcdOvmfFlashVariablesEnable|TRUE
gQemuPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0x29C0

# CMOS region is 128 bytes
gMsWheaPkgTokenSpaceGuid.PcdMsWheaReportEarlyStorageCapacity|0x80

[PcdsFixedAtBuild.IA32]
#
# The NumberOfPages values below are ad-hoc. They are updated sporadically at
Expand Down Expand Up @@ -1348,7 +1351,7 @@
MsCorePkg/UnitTests/MathLibUnitTest/MathLibUnitTestApp.inf
# MsGraphicsPkg/UnitTests/SpinnerTest/SpinnerTest.inf # DOESN'T PRODUCE OUTPUT
MsWheaPkg/Test/UnitTests/Library/LibraryClass/CheckHwErrRecHeaderTestApp.inf
MsWheaPkg/Test/UnitTests/MsWheaEarlyStorageUnitTestApp/MsWheaEarlyUnitTestApp.inf
# MsWheaPkg/Test/UnitTests/MsWheaEarlyStorageUnitTestApp/MsWheaEarlyUnitTestApp.inf # CMOS REGION TOO SMALL TO STORE DATA
MsWheaPkg/Test/UnitTests/MsWheaReportUnitTestApp/MsWheaReportUnitTestApp.inf
MmSupervisorPkg/Test/MmPagingAuditTest/UEFI/MmPagingAuditApp.inf
MmSupervisorPkg/Test/MmSupvRequestUnitTestApp/MmSupvRequestUnitTestApp.inf
Expand Down
1 change: 0 additions & 1 deletion Platforms/QemuSbsaPkg/PlatformBuild.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
FAILURE_EXEMPT_TESTS = {
"BootAuditTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0),
"LineParserTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0),
"MsWheaEarlyUnitTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0),
"VariablePolicyFuncTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0),
"DeviceIdTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0),
"DxePagingAuditTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0),
Expand Down
2 changes: 1 addition & 1 deletion Platforms/QemuSbsaPkg/QemuSbsaPkg.dsc
Original file line number Diff line number Diff line change
Expand Up @@ -1197,7 +1197,7 @@
MsCorePkg/UnitTests/MathLibUnitTest/MathLibUnitTestApp.inf
# MsGraphicsPkg/UnitTests/SpinnerTest/SpinnerTest.inf # DOESN'T PRODUCE OUTPUT
MsWheaPkg/Test/UnitTests/Library/LibraryClass/CheckHwErrRecHeaderTestApp.inf
MsWheaPkg/Test/UnitTests/MsWheaEarlyStorageUnitTestApp/MsWheaEarlyUnitTestApp.inf
# MsWheaPkg/Test/UnitTests/MsWheaEarlyStorageUnitTestApp/MsWheaEarlyUnitTestApp.inf # NO EARLY STORE METHOD AVAILABLE ON ARM
MsWheaPkg/Test/UnitTests/MsWheaReportUnitTestApp/MsWheaReportUnitTestApp.inf
# MmSupervisorPkg/Test/MmPagingAuditTest/UEFI/MmPagingAuditApp.inf # NOT APPLICABLE TO SBSA
# MmSupervisorPkg/Test/MmSupvRequestUnitTestApp/MmSupvRequestUnitTestApp.inf # NOT APPLICABLE TO SBSA
Expand Down

0 comments on commit 7453bf9

Please sign in to comment.