Stop controller during app teardown (#34)

pyproject.toml

@@ -18,7 +18,6 @@ dearpygui-ext = "^0.9.5"
 
 [tool.poetry.group.dev.dependencies]
 pytest = "^7.2.2"
-pytest-order = "^1.2.1"
 mypy = "^1.2.0"
 pillow = "^10.3.0"
 pyautogui = "^0.9.54"

src/can_explorer/app.py

@@ -54,8 +54,9 @@ def setup(self):
 
         dpg.set_primary_window(app, True)
 
-    @staticmethod
-    def teardown():
+    def teardown(self):
+        if self.controller.is_active():
+            self.controller.stop()
         dpg.destroy_context()
 
     def exception_handler(self, exc_type, exc_value, exc_traceback):

tests/test_controller.py

@@ -28,4 +28,4 @@ def test_controller_populates_data_in_ascending_order(controller, view, vbus1, v
 
     time.sleep(0.1)
     plots = view.plot.get_rows()
-    assert list(plots) == sorted(plots)
+    assert plots and list(plots) == sorted(plots)

tests/test_gui.py

@@ -15,8 +15,6 @@
 from tests.resources import WITHIN_CI
 from tests.resources.gui_components import Gui
 
-pytestmark = pytest.mark.order(1)
-
 if HOST_OS == "linux":
     import Xlib.display
     from pyvirtualdisplay.smartdisplay import SmartDisplay