🔀 :: [#210] 로그인 버튼 GAuth 버튼으로 리펙토링 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uuuunseo
added
🔨 Refactor
uuuunseo
requested review from
baekteun,
kimsh153,
minaje0917,
MelBIP and
junseopark0331
as code owners
Closed
baekteun
reviewed
Nov 27, 2023
baekteun
reviewed
Nov 27, 2023
junseopark0331
approved these changes
Nov 27, 2023
baekteun
reviewed
Nov 27, 2023
|
UI 관련 변경사항이 있으니 스크린샷이 있어야할거같아용 |
baekteun
reviewed
Nov 27, 2023
Projects/Feature/SigninFeature/Sources/Scene/SigninViewController.swift
Outdated
Show resolved
Hide resolved
Projects/Feature/SigninFeature/Sources/Scene/SigninViewController.swift
Outdated
Show resolved
Hide resolved
Projects/Feature/SigninFeature/Sources/Scene/SigninViewController.swift
Outdated
Show resolved
Hide resolved
추가했어요! |
baekteun
reviewed
Nov 27, 2023
Projects/Feature/SigninFeature/Sources/Scene/SigninViewController.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Nov 27, 2023
Projects/Feature/SigninFeature/Sources/Scene/SigninViewController.swift
Outdated
Show resolved
Hide resolved
…ler.swift Co-authored-by: baegteun <baegteun@gmail.com>
baekteun
reviewed
Nov 27, 2023
Projects/Feature/SigninFeature/Sources/Scene/SigninViewController.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Nov 27, 2023
Projects/Feature/SigninFeature/Sources/Scene/SigninViewController.swift
Outdated
Show resolved
Hide resolved
…ler.swift Co-authored-by: baegteun <baegteun@gmail.com>
minaje0917
approved these changes
Nov 27, 2023
baekteun
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
로그인 버튼 GAuth 버튼으로 리펙토링
📃 작업내용
기존 로그인 버튼을 GAuth로그인 버튼으로 리펙토링 했습니다.
🔀 변경사항
emailTextField, passwordTextField, renewalPasswordButton, signupButton이 삭제 되었습니다.