Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 :: struct로 된 공유 객체들의 타입을 class로 변경 및 싱글톤 DI #64

Merged
merged 2 commits into from
Jul 6, 2023
Merged

🔀 :: struct로 된 공유 객체들의 타입을 class로 변경 및 싱글톤 DI #64

merged 2 commits into from
Jul 6, 2023

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Jul 6, 2023

💡 개요

  • struct로 된 공유 객체들을 class로 변경합니다.
  • 또한 DI를 할 때 공유가 많이 되는 객체들의 경우 단일 객체 하나로 여러번 우려먹기 할 수 있게 DI를 합니다

📃 작업내용

  • struct to class
  • Swinject Container scope for Singleton DI

@baekteun baekteun added 🔨 Refactor 코드 리팩토링 2️⃣Priority: Medium 우선순위 중 labels Jul 6, 2023
@baekteun baekteun self-assigned this Jul 6, 2023
@baekteun baekteun requested a review from kimsh153 as a code owner July 6, 2023 02:43
@baekteun baekteun linked an issue Jul 6, 2023 that may be closed by this pull request
struct로 된 공용 객체들 class로 변경 #60
Closed
@baekteun baekteun merged commit 0d775b4 into master Jul 6, 2023
@baekteun baekteun deleted the 60-common-struct-to-class branch July 6, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimsh153 kimsh153 kimsh153 approved these changes

@minaje0917 minaje0917 minaje0917 approved these changes

@MelBIP MelBIP Awaiting requested review from MelBIP

@junseopark0331 junseopark0331 Awaiting requested review from junseopark0331 junseopark0331 is a code owner

@uuuunseo uuuunseo Awaiting requested review from uuuunseo uuuunseo is a code owner

Assignees

@baekteun baekteun

Labels
2️⃣Priority: Medium 우선순위 중 🔨 Refactor 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

struct로 된 공용 객체들 class로 변경
3 participants
@baekteun @minaje0917 @kimsh153