Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 :: [#79] 공지Feature 구현 #91

Merged
merged 59 commits into from
Jul 24, 2023
Merged

🔀 :: [#79] 공지Feature 구현 #91

merged 59 commits into from
Jul 24, 2023

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Jul 23, 2023 •
edited
Loading

💡 개요

📃 작업내용

  • NoticeFeature 구현
  • TableViewAdapter
  • UIKitUtil Module
  • BaseTableViewCell

@baekteun
✨ [#79] :: Notice Feature Demo App 추가
0aeb200
@baekteun
✨ [#79] :: Demo AppDelegate 세팅
3b6b216
@baekteun
✨ [#79] :: Notice Moordinator 설정
36e10e0
@baekteun
♻️ :: [#79] DotoriBarButton 컴포넌트화
d62350d
@baekteun
🔥 :: [#79] HomeViewController 사용하지 않는 scrollView 제거
3fbbedc
@baekteun
🚚 :: HomewViewController -> HomeViewController
b0b4bca
@baekteun
♻️ :: [#79] Home / 불필요한 lazy var -> let
2009d02
@baekteun
💄 :: [#79] Notice / 공지 섹션 타이틀
77f12cf
@baekteun
✨ :: [#79] UIKitUtil / UIKitUtil 모듈 생성
955988c
@baekteun
➕ :: UIKitUtil -> BaseFeature, DesignSystem
5674379
@baekteun
✨ :: [#79] :: UIKitUtil / TableViewAdapter
562ee02
@baekteun
✨ :: [#79] :: BaseFeature / BaseTableViewCell
f0e34c9
@baekteun
✨ [#79] :: NoticeFeature / Notice Cell File
d1fc148
@baekteun
✨ :: [#79] UIKitUtil / Reusable
5ddd58a
@baekteun
💄 :: [#79] NoticeFeature / NoticeCell UI
799731b
@baekteun
✨ :: [#79] NoticeDomain / NoticeDomain 모듈 생성
c8eea36
@baekteun
✨ :: [#79] NoticeDomain / fetchNoticeUseCase Interfaces
f15f317
@baekteun
✨ :: [#79] NoticeDomain / FecthNoticeListUseCase Impl
410d25d
@baekteun
✨ :: [#79] NoticeDomain / FetchNoticeUseCase Spy
9606215
@baekteun
✅ :: [#79] NoticeDomain / NoticeRepository, FetchNoticeListUseCase Tests
44b56e6
@baekteun
✨ :: [#79] App / NoticeDomain DI
cf471ac
@baekteun
💄 :: [#79] NoticeFeature / NoticeCell Cell간 spacing
13210db
@baekteun
♻️ :: [#79] Adapter에서 TableView관리
31ff4fc
@baekteun
✨ :: [#79] UIKitUtil / TableViewAdapter에 header, footer customize 추가
8fac971
@baekteun
♻️ :: [#79] UIKitUtil / SectionModel에서 관리하는 것이 아닌 TableViewAdapter에서 …
0e881ed 
…관리하도록 변경
@baekteun
💄 :: [#79] NoticeFeature / 공지 섹션
4334b5d
@baekteun
💄 :: [#79] NoticeFeature / NoticeViewController backgroundColor Backg…
f959338 
…round/Bg -> Background/Card
@baekteun
✨ :: [#79] NoticeFeature / NoticeViewController ViewDidLoad Notice데이터…
aa2376f 
… 바인딩
@baekteun
✨ :: [#79] NoticeFeature / 공지를 연,월에 따라 섹션 나누기 및 섹션 Label
ae27f2a
@baekteun
✏️ :: [#79] NoticeDomain / API명세서와 실제 Response값이 다른 현상
d77a114
@baekteun baekteun added 0️⃣Priority: Critical 우선순위 긴급 ✨ Feature 기능 개발 labels Jul 23, 2023
@baekteun baekteun self-assigned this Jul 23, 2023
@baekteun baekteun linked an issue Jul 23, 2023 that may be closed by this pull request
공지사항 Feature 구현 #79
Closed
@baekteun
🔥 :: [#79] NoticeDomain / NoticeDomainInterface에 불필요한 UserDomainInter…
3aa1b61 
…face 의존성 제거
@baekteun
✅ :: [#79] UserDomain / LocalUserDataSourceTest에 BaseDomainInterface …
1fc87b9 
…import
@baekteun
➕ :: [#79] HomeFeature / HomeFeatureTests에 Testing모듈 의존성 추가
0a90d97
@baekteun
➕ :: [#79] NoticeDomain / Notice,UserDomainTesting -> NoticeFeatureTests
f553ea3
@baekteun
✨ :: [#79] NoticeFeature / 공지 가져오는 시점 viewWillAppear, viewDidLoad 분리
ea5b146
@baekteun
✅ :: [#79] NoticeFeature / 공지 가져오는 상태와 Section으로 분리된 공지 상태 Tests
a48c523
@baekteun
✅ :: [#79] NoticeFeature / EditButton 탭할 시의 Action Tests
ef88412
@baekteun
🚨 :: [#79] NoticeFeature / action당 Assertion하는 코드스타일로 변경
9ffff34
@baekteun
✅ :: [#79] NoticeFeature / test_RouteNoticeDetail_When_NoticeDidTap_A…
9e09b51 
…nd_IsEditingFalse
@baekteun
✅ :: [#79] NoticeFeature / test_InsertSelectedNotice_When_NoticeDidTa…
db3e00c 
…p_And_IsEditingTrue
@baekteun
✅ :: [#79] NoticeFeature / Section DateFormat 방식 DateUtility의 extensi…
cad3925 
…no활용 (차후 formatting객체 분리)
@baekteun
💄 :: [#79] DesignSystem / DotoriButton 다크,라이트 TextColor 분기 처리 (light …
0607f8b 
…- n50, dark - n20)
@baekteun baekteun merged commit 3b39a48 into master Jul 24, 2023
@baekteun baekteun deleted the 79-notice-feature-impl branch July 24, 2023 02:55
@baekteun baekteun changed the title 🔀 :: 공지Feature 구현 🔀 :: [#79] 공지Feature 구현 Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minaje0917 minaje0917 minaje0917 approved these changes

@kimsh153 kimsh153 Awaiting requested review from kimsh153 kimsh153 is a code owner

@MelBIP MelBIP Awaiting requested review from MelBIP

@junseopark0331 junseopark0331 Awaiting requested review from junseopark0331 junseopark0331 is a code owner

@uuuunseo uuuunseo Awaiting requested review from uuuunseo uuuunseo is a code owner

Assignees

@baekteun baekteun

Labels
0️⃣Priority: Critical 우선순위 긴급 ✨ Feature 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

공지사항 Feature 구현
2 participants
@baekteun @minaje0917